Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#38917] - Fixes php 8.1 strtoupper deprecation error in patch tester

? ? Pending

User tests: Successful: Unsuccessful:

avatar N6REJ
N6REJ
8 Oct 2022

Pull Request for Issue # .

Summary of Changes

Removes the warning
Deprecated: strtoupper(): Passing null to parameter #1 ($string) of type string is deprecated in E:\Bearsampp\www\j4\libraries\src\MVC\Model\ListModel.php on line 543 that shows up in patch_tester 4.2.1 when using php 8.1+

Testing Instructions

install https://github.com/joomla-extensions/patchtester/releases/tag/4.2.1
when you open it you will see the error at the top of the page.
enter your credentials and apply this patch.

Actual result BEFORE applying this Pull Request

image

Expected result AFTER applying this Pull Request

image

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar N6REJ N6REJ - open - 8 Oct 2022
avatar N6REJ N6REJ - change - 8 Oct 2022
Status New ⇒ Pending
avatar N6REJ N6REJ - change - 8 Oct 2022
Title
…
fixes php 8.1 strupper deprecation error in patch tester
Fixes php 8.1 strupper deprecation error in patch tester
avatar N6REJ N6REJ - edited - 8 Oct 2022
avatar joomla-cms-bot joomla-cms-bot - change - 8 Oct 2022
Category ⇒ Libraries
avatar N6REJ N6REJ - change - 8 Oct 2022
Title
…
Fixes php 8.1 strupper deprecation error in patch tester
Fixes php 8.1 strtoupper deprecation error in patch tester
avatar N6REJ N6REJ - edited - 8 Oct 2022
avatar N6REJ N6REJ - change - 8 Oct 2022
Labels Added: ?
avatar toivo
toivo - comment - 9 Oct 2022

I have tested this item ✅ successfully on ed1e20e

Tested successfully in Joomla 4.2.4-dev of 30 September using PHP 8.1.9 in Wampserver 3.2.9.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38917.

avatar toivo toivo - test_item - 9 Oct 2022 - Tested successfully
avatar viocassel
viocassel - comment - 9 Oct 2022

I have tested this item ✅ successfully on ed1e20e

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38917.

avatar viocassel viocassel - test_item - 9 Oct 2022 - Tested successfully
avatar richard67 richard67 - change - 9 Oct 2022
Status Pending ⇒ Ready to Commit
avatar richard67
richard67 - comment - 9 Oct 2022

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38917.

avatar richard67 richard67 - change - 15 Oct 2022
Status Ready to Commit ⇒ Pending
avatar richard67
richard67 - comment - 15 Oct 2022

Back to pending status.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38917.

avatar N6REJ
N6REJ - comment - 15 Oct 2022

We don't use ?? '' to fix php warnings, there is actually a reason why it's not a string and in this case NULL, if it's really expected that the direction value is NULL we should find the root cause, and create an if statement before if in_array query.

you want to create a pr then. Thats not something I'm capable of doing.

avatar N6REJ N6REJ - change - 17 Oct 2022
Status Pending ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2022-10-17 20:18:04
Closed_By ⇒ N6REJ
Labels Added: ?
avatar N6REJ N6REJ - close - 17 Oct 2022

Add a Comment

Login with GitHub to post a comment