The code to install the CMS is quite a mess and pretty inconsistent. The configuration sometimes is expected as an array, sometimes as an object. Sometimes the configuration is handed in from the outside, sometimes it is retrieved by the model itself from the session. The form validation code is not done like in the rest of the CMS by the controller calling the methods in the model, but the controller is calling a special method in the model, which then again does the validation calls...
Goals of this PR:
The configuration is explicitely given the model as method parameter. This also improves the code of the CLI installation.
The configuration is used as an array
The code is cleaned up to confirm to our regular flow of execution elsewhere in the CMS.
Functions are decoupled in a better way to better integrate with the CLI installer
Link to documentations
No documentation changes for docs.joomla.org needed
No documentation changes for manual.joomla.org needed
It seems there are errors in the PR that have to been checked and fixed. Seems the first form is not preserved... @Hackwar I didn't discovered this while testing. @wilsonge reported it to me
So I accidentally added the wrong db admin to the form. Clicked submit and got the correct error (n.b. I didn't see the progress bar at this point). The form data is preserved in that sense (probably too well!). However, when fixing the error in the form and submitting again I got the error that @fancyFranci obtained and had no way to resolve it or go back. I had to refresh the page and enter all information again.
Yeah this definitely broke stuff - but only if you clear your cookies out in the meantime because this doesn't refresh after data is updated in the session. See #41942
joomla-cms-bot
- 
richard67
- 
I have tested this item✅ successfully on ec4c946
Installation works well, install additional languages work well, tried to enter wrong credentials..., all still work.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38914.