? Success

User tests: Successful: Unsuccessful:

avatar peterlose
peterlose
12 Jul 2014

At the moment com_languages aren't presented very nice on small viewports. I've added a few class="hidden-phone" to the table elements:

old

vs.

new

The elements which are hidden on small viewports are: version, date, author and author email

avatar losedk losedk - open - 12 Jul 2014
avatar dbhurley
dbhurley - comment - 12 Jul 2014

Looks good! Thanks :) Keep finding these :+1:

avatar losedk
losedk - comment - 12 Jul 2014

The languages view in com_languages are also pretty messed up on small viewports:

Do you guys have any opinion about what to hide here?

languages

avatar dbhurley
dbhurley - comment - 12 Jul 2014

Home / ID / Language Tag / and then either Language Code or Image Prefix. When on mobile what is more important? If Image Prefix shows the same as language code then I prefer the one with the graphic...again, just keeping in mind what I am looking for when on mobile.

avatar losedk
losedk - comment - 12 Jul 2014

Something like this?

skrmbillede 2014-07-12 kl 21 37 30

avatar dbhurley
dbhurley - comment - 12 Jul 2014

ah, totally my fault, those are the fields I would remove - you asked which ones I would "hide".

avatar losedk
losedk - comment - 12 Jul 2014

Ahh my bad :)

skrmbillede 2014-07-12 kl 21 41 34

avatar dbhurley
dbhurley - comment - 12 Jul 2014

That works for me, though I must admit I hate having 3 lines for the Language code. Do you think we need Title & Native Title for mobile? What if we have just Title, Code and Access?

avatar losedk
losedk - comment - 12 Jul 2014

It will be 3 lines regardless:

skrmbillede 2014-07-12 kl 21 47 33

avatar dbhurley
dbhurley - comment - 12 Jul 2014

well, my preference would be these three and the image then (images are pretty and quick to see with the eye) if URL will always be 3 lines. Might as well add the graphic in as well. :)

avatar sanderpotjer
sanderpotjer - comment - 12 Jul 2014

Would indeed suggest to have the language flag listed as well.

avatar losedk
losedk - comment - 12 Jul 2014

That works for me to

skrmbillede 2014-07-12 kl 21 50 57

avatar dbhurley
dbhurley - comment - 12 Jul 2014

+1 Looks good.

avatar losedk
losedk - comment - 12 Jul 2014

Updated the PR based on our dicussion

avatar Hils
Hils - comment - 12 Jul 2014

This is probably a separate issue, but why does it say en for English (UK) - it should be en-GB

avatar dbhurley
dbhurley - comment - 12 Jul 2014

I saw that as well. I'm calling that a separate issue ;)

avatar Hils
Hils - comment - 12 Jul 2014

I hope @JM sees it as it might be like that for a reason ;)

avatar n9iels
n9iels - comment - 12 Jul 2014

The patch doesn't work for me. See screenshot for my result, tested on Joomla! 3.2.2-dev
knipsel

avatar losedk
losedk - comment - 12 Jul 2014

Was missing a hidden-phone. @n9iels could you try again?

avatar n9iels
n9iels - comment - 12 Jul 2014

That looks great :-) exactly like the screenshot your post
So @test works fine for me

avatar brianteeman
brianteeman - comment - 12 Jul 2014

@hils @dbhurley en is correct for the fields being displayed

avatar losedk
losedk - comment - 15 Jul 2014

Think it's RTC, if people agree with the suggestions of course.

avatar Bakual Bakual - change - 15 Jul 2014
Status New Closed
Closed_Date 0000-00-00 00:00:00 2014-07-15 17:28:58
avatar Bakual Bakual - close - 15 Jul 2014

Add a Comment

Login with GitHub to post a comment