Feeling Lucky
?
?
[#38863] - [4.2] codemirror full screen
- Fixed in Code Base
- 7 Oct 2022
- Medium
- Build: 4.2-dev
- # 38863
- Diff
- brianteeman:readonly
User tests: Successful: Unsuccessful:
In com_templates if you display the original file as well as the override then you have two instances of codemirror with the original file as readonly. Both have the message "Press xx to toggle Full Screen editing" which doesnt make sense on a readonly instance of the editor and not surprisingly doesnt work.
This PR removes the message and associated options from the codemirror layout if the editor is defined as readonly in the xml
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
viocassel
- comment
- 6 Oct 2022
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38863.
| Status | Pending | ⇒ | Ready to Commit |
alikon
- comment
- 6 Oct 2022
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38863.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-10-07 13:08:27 |
| Closed_By | ⇒ | roland-d |
roland-d
- comment
- 7 Oct 2022
Thank you
I have tested this item✅ successfully on c944a91
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38863.