Feeling Lucky
?
[#3886] - [#32131] Refactored method to use server variables
- Closed
- 13 Aug 2014
- Medium
- Build: staging
- # 3886
- Diff
- vdespa:iss-32131
- Foreign ID 32131
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
| Title |
|
||||||
| Title |
|
||||||
| Labels |
Added:
?
?
|
||||||
brianteeman
- | Labels |
Added:
?
|
||
phproberto
- | Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-08-13 01:34:11 |
infograf768
- comment
- 14 Aug 2014
Please look at
#3423 (comment)
Bakual
- comment
- 14 Aug 2014
Reverted this PR since Jenkins failed on it:
JDatabaseDriverMysqlTest::testGetCollation
Line:130 The getCollation method should return the collation of the database.
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'utf8_general_ci'
+'latin1_swedish_ci'
/var/lib/jenkins/jobs/cms/workspace/tests/unit/suites/database/driver/mysql/JDatabaseDriverMysqlTest.php:131
and
JDatabaseDriverMysqliTest::testGetCollation
Line:130 The getCollation method should return the collation of the database.
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'utf8_general_ci'
+'latin1_swedish_ci'
/var/lib/jenkins/jobs/cms/workspace/tests/unit/suites/database/driver/mysqli/JDatabaseDriverMysqliTest.php:131
mbabker
- comment
- 14 Aug 2014
In defense of this patch, it could just be how the database is set up on the server and not an issue with the patch. I'm in there now looking at it to see what I can do with it.
mbabker
- comment
- 14 Aug 2014
Re-committed after rebuilding the test database on Jenkins to use the expected collation.
zero-24
- comment
- 15 Aug 2014
@mbabker Jenkins still fail with:
JDatabaseDriverMysqlTest::testGetCollation
Line:130 The getCollation method should return the collation of the database.
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'utf8_general_ci'
+'utf8_unicode_ci'
/var/lib/jenkins/jobs/cms/workspace/tests/unit/suites/database/driver/mysql/JDatabaseDriverMysqlTest.php:131
and
JDatabaseDriverMysqliTest::testGetCollation
Line:130 The getCollation method should return the collation of the database.
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'utf8_general_ci'
+'utf8_unicode_ci'
/var/lib/jenkins/jobs/cms/workspace/tests/unit/suites/database/driver/mysqli/JDatabaseDriverMysqliTest.php:131
See: http://build.joomla.org/job/cms/lastCompletedBuild/testReport/
mbabker
- comment
- 15 Aug 2014
Fixed. So many possible collations...
Sophist-UK
-
@vdespa Good work. Thanks!
Can be merged, works as described.