[#38853] - Fix Dashboards for third party components
- Fixed in Code Base
- 29 Sep 2022
- Medium
- Build: 4.2-dev
- # 38853
- Diff
- nikosdion:fix/38849-dashboard
User tests: Successful: Unsuccessful:
Pull Request for Issue #38849 .
Summary of Changes
Updated \Joomla\Component\Cpanel\Administrator\View\Cpanel\HtmlView::display to make the control panel position on third party components' dashboards independent of the Unicode Slugs setting in Global Configuration.
Testing Instructions
- Install a new site.
- Install an extension with a custom Dashboard, e.g. https://www.akeeba.com/download/arsdev/7-1-0-dev202209271443-revc1215dcb.html
TEST 1
- Go to System, Global Configuration, Site.
- Set Unicode Aliases to No (that's the default).
- Click on Save & Close.
- TEST 1.A: Go to extension's dashboard (e.g. Components, and click the dashboard icon next to Akeeba Release System)
- TEST 1.B: Go to the Joomla administrator control panel.
TEST 2
- Go to System, Global Configuration, Site.
- Set Unicode Aliases to Yes.
- Click on Save & Close.
- TEST 2.A: Go to extension's dashboard (e.g. Components, and click the dashboard icon next to Akeeba Release System)
- TEST 2.B: Go to the Joomla administrator control panel.
Actual result BEFORE applying this Pull Request
Test 1.A: The component dashboard is NOT shown
Test 1.B: The system dashboard is shown
Test 2.A: The component dashboard is shown
Test 2.B: The system dashboard is shown
Expected result AFTER applying this Pull Request
Test 1.A: The component dashboard is shown
Test 1.B: The system dashboard is shown
Test 2.A: The component dashboard is shown
Test 2.B: The system dashboard is shown
Documentation Changes Required
Technically, none.
Please note that there's currently zero documentation on custom dashboards. I am writing it which is how I bumped into this issue to begin with.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_cpanel |
| Labels |
Added:
?
|
||
For testing without extra component:
Add var_dump($dashboard, $position); around here (after $position = ..)
In backend open administrator/index.php?option=com_cpanel&view=cpanel&dashboard=com_potato-test,
You should get var_dump output:
com_potato-test
com-potato-test
Then in Global configuration change Unicode Aliases to oposite of what you have.
Check previous link again, the var_dump output should be the same.
Before the patch it diferent (when Unicode Aliases is Yes ):
com_potato-test
com_potato-test
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38853.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38853.
| Status | Pending | ⇒ | Ready to Commit |
r2c
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38853.
I have tested this item
What I am doing wrong? Testing in J4.2.3 with php8.1.7
Without the patch the test completes as expected.
Test 1A Not shown
Test 1B Shown
Test 2A Shown
Test 2B Shown
After applying the patch
Test 1A Not Shown
Test 1B Shown
Test 2A Not Shown
Test 2B Shown
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38853.
@Abernyte-Git It's because I have a bug in the component I asked you to test with. I have mistyped the position as cpanel-com_ars-ars instead of cpanel-com-ars-ars. Well, you got the correct results for my typo…
Phew! I thought I was losing it! I will retest whenever your component is fixed.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38853.
| Labels |
Added:
?
|
||
@nikosdion just to be sure. I tested it with your version of ARS and after the update it adds the modules at the position "cpanel-com_ars-ars" but it should be "cpanel-com-ars-ars". Because this is what is rendered after the change in this as $position in the view. Is this correct?
As I said yesterday, it's a typo in my component. I mean to fix that but life got in the way. When I have some time later today or tomorrow I'll update the component.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-09-29 14:09:09 |
| Closed_By | ⇒ | laoneo |
Thanks for clarification and the pr!
Looks valid,
Btw, your extension not available for download, people will not be able to test ;)