Feature RTC Language Change a11y NPM Resource Changed PBF UI/UX PR-5.1-dev Pending

User tests: Successful: Unsuccessful:

avatar chmst
chmst
20 Sep 2022

Pull Request for Issue # .

Summary of Changes

Make headline in categories like headline in menus. There is plenty of place for text and is better a11y and usability.

Testing Instructions

Compare menus and categories view in backend

Actual result BEFORE applying this Pull Request

grafik

grafik

Expected result AFTER applying this Pull Request

grafik

Votes

# of Users Experiencing Issue
1/2
Average Importance Score
3.50

avatar chmst chmst - open - 20 Sep 2022
avatar chmst chmst - change - 20 Sep 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 20 Sep 2022
Category Administration com_categories Language & Strings
avatar brianteeman
brianteeman - comment - 20 Sep 2022

If this change is going to be made thn it needs to be made everywhere - I know of at least banners-clients that would also need to be updated - there may be others.

Also its not a bug fix so it should be in 4.3 i think

avatar chmst
chmst - comment - 20 Sep 2022

agree.
Do you see any problems there? It is better UX and better a11y.

avatar brianteeman
brianteeman - comment - 20 Sep 2022

Not sure myself that it's better anything, but it must be at least consistent

avatar crystalenka
crystalenka - comment - 20 Sep 2022

I think this is definitely more clear, at least in desktop. What happens in mobile?

consistency is of course important, but let's figure out the best pattern and then we can see where else it needs to be implemented. :)

avatar chmst
chmst - comment - 20 Sep 2022

Ithas to be made equal for all categories. Now we havean inconsitency. Why I prefer this versoin? Because we make text invisible when there is plenty of place, no need for ugly titles. The dropdown for hiding columns says "archived items" - is it obvious that the folder icon stands for archived items?
You know that of course - but a new user?

avatar chmst
chmst - comment - 20 Sep 2022

@crystalenka on mobile these columns are not displayed at all.

avatar brianteeman
brianteeman - comment - 20 Sep 2022

will you be updating banner-clients?

avatar chmst
chmst - comment - 20 Sep 2022

There are all categories views - banner, newsfeed, contacts (also weblinks). Maybe user notes .. I must investigate.

If the pattern is accepted then I can do it (but after my holidays). I can set this on draft, so nothing happens befor all is consistent.

avatar brianteeman
brianteeman - comment - 20 Sep 2022

There are all categories views - banner, newsfeed, contacts (also weblinks). Maybe user notes .. I must investigate.

I checked them

avatar chmst chmst - change - 24 Oct 2022
Labels Added: Language Change a11y PR-4.3-dev ?
avatar joomla-cms-bot joomla-cms-bot - change - 24 Oct 2022
Category Administration com_categories Language & Strings Administration com_banners com_categories Language & Strings
avatar coolcat-creations
coolcat-creations - comment - 25 Oct 2022

I have tested this item successfully on c82adbf

Tested this successfully, thank you!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38787.

avatar coolcat-creations coolcat-creations - test_item - 25 Oct 2022 - Tested successfully
avatar crystalenka
crystalenka - comment - 25 Oct 2022

Tested successfully, but not submitting it on the tracker because I am reconsidering my earlier comment after seeing it in different components. :/

The labels are indeed more clear than only icons, but I am currently on my laptop which has a smaller screen and in some components, this change means that there is significantly less white space and a lot of visual weight is given to these counters when they're not necessarily the most critical part of these views:

Banners: Clients screen

Smart search: content maps

Articles: categories

As a result, even though the labels are more clear, the interface is harder to understand because the eye doesn't know where to go.

I agree both that the original pattern isn't very clear and that it should be consistent across all views like this, but I think we need to take a step back and find a different approach so it can be both clear and meaningful.

I was wrong before to make an opinion without seeing how it affected other components; apologies that you spent additional time on it just for me to come in and suggest a different direction. :(

avatar brianteeman
brianteeman - comment - 25 Oct 2022

@crystalenka thats why they were not given heading texts originally. It would be good if people remembered that previous work was not done on a whim without any thought.

avatar crystalenka
crystalenka - comment - 25 Oct 2022

@crystalenka thats why they were not given heading texts originally. It would be good if people remembered that previous work was not done on a whim without any thought.

No one implied that. Previous work is important; we also need to be open to improving and getting better as we learn and grow. I think there is a solution that solves both problems but need to think through it more.

avatar chmst
chmst - comment - 25 Oct 2022

The smart search content map was not changed in this PR. I would remove the "indexed content" from the language string.
I can do that if you want.

In any case, these informations should be consistent. We have

  • the "verbose" version in com_menus
  • the "very verbose" version in smart search
  • the "icons only" in categories and banners

So we were not consequent in the past.

But if the JXT wants to make a concept which meets all needs, I will be happy. Maybe a separator or very light background could make it better.

avatar Quy
Quy - comment - 26 Jan 2023

Maybe add a legend in the footer similar to Permissions.

legend

avatar HLeithner HLeithner - change - 5 Oct 2023
Title
Menus and categories view with equal headline
[5.1] Menus and categories view with equal headline
avatar HLeithner HLeithner - edited - 5 Oct 2023
avatar HLeithner HLeithner - change - 5 Oct 2023
Title
[5.1] Menus and categories view with equal headline
[5.0] Menus and categories view with equal headline
avatar HLeithner HLeithner - edited - 5 Oct 2023
avatar HLeithner HLeithner - change - 7 Oct 2023
Title
[5.0] Menus and categories view with equal headline
[5.1] Menus and categories view with equal headline
avatar HLeithner HLeithner - edited - 7 Oct 2023
avatar dennise24 dennise24 - test_item - 24 Feb 2024 - Tested successfully
avatar dennise24
dennise24 - comment - 24 Feb 2024

I have tested this item ✅ successfully on 462b155

I have tested this item ✅ successfully


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38787.

avatar hannazn hannazn - test_item - 24 Feb 2024 - Tested successfully
avatar hannazn
hannazn - comment - 24 Feb 2024

I have tested this item ✅ successfully on 462b155

I have tested this item ✅ successfully


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38787.

avatar richard67 richard67 - change - 24 Feb 2024
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 24 Feb 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38787.

avatar peterpeter peterpeter - test_item - 24 Feb 2024 - Tested unsuccessfully
avatar peterpeter
peterpeter - comment - 24 Feb 2024

I have tested this item ? unsuccessfully on 462b155

Got an error:
500 Layout default_batch_footer not found.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38787.

https://prnt.sc/s257iDiogD3c

avatar dorisdreher dorisdreher - test_item - 24 Feb 2024 - Tested unsuccessfully
avatar dorisdreher
dorisdreher - comment - 24 Feb 2024

I have tested this item ? unsuccessfully on 462b155

Error in Articles Categories after installation
An error has occurred.
500 Layout default_batch_footer not found.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38787.
avatar adj9 adj9 - test_item - 24 Feb 2024 - Not tested
avatar adj9
adj9 - comment - 24 Feb 2024

I have not tested this item.

In Safari 15.6.1 I don't see the difference


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38787.
Schermata 2024-02-24 alle 12 08 04

avatar robertolongo robertolongo - test_item - 24 Feb 2024 - Tested unsuccessfully
avatar robertolongo
robertolongo - comment - 24 Feb 2024

I have tested this item ? unsuccessfully on 462b155

I tested the patch with 5.1.0-alpha1 and ‎5.1.0-alpha4
and I encountered the following error:

An error has occurred.
500 Layout default_batch_footer not found.

image


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38787.
avatar richard67
richard67 - comment - 24 Feb 2024

To all who get the error "500 Layout default_batch_footer not found.": How have you applied the pull request and on which Joomla version? That layout has been removed in 5.1 meanwhile.

I will trigger a new build of the testing packages for download right now. Maybe they were not up to date with that change.

You can test again when the downloads are available again.

avatar richard67 richard67 - change - 24 Feb 2024
Labels Added: Feature RTC PBF UI/UX PR-5.1-dev
Removed: PR-4.3-dev ?
avatar faustonenci faustonenci - test_item - 24 Feb 2024 - Tested successfully
avatar faustonenci
faustonenci - comment - 24 Feb 2024

I have tested this item ✅ successfully on 462b155

good work


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38787.

avatar peterpeter
peterpeter - comment - 24 Feb 2024

@richard67
Joomla 5.1.0-alpha4 with pre-installed com_patchtester from server list on
pizza-bugs-fun.com


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38787.

avatar robertolongo robertolongo - test_item - 24 Feb 2024 - Tested successfully
avatar robertolongo
robertolongo - comment - 24 Feb 2024

I have tested this item ✅ successfully on 77281df

@peterpeter @dorisdreher
After the drone rebuilder, it works!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38787.

avatar peterpeter peterpeter - test_item - 24 Feb 2024 - Tested successfully
avatar peterpeter
peterpeter - comment - 24 Feb 2024

I have tested this item ✅ successfully on 77281df

Works now ?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38787.

avatar joomla-cms-bot joomla-cms-bot - change - 2 Mar 2024
Category Administration com_categories Language & Strings com_banners Administration com_banners com_categories Language & Strings NPM Change
avatar bembelimen bembelimen - change - 2 Mar 2024
Labels Added: NPM Resource Changed
avatar LadySolveig LadySolveig - change - 2 Mar 2024
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2024-03-02 16:48:34
Closed_By LadySolveig
avatar LadySolveig LadySolveig - close - 2 Mar 2024
avatar LadySolveig LadySolveig - merge - 2 Mar 2024
avatar LadySolveig
LadySolveig - comment - 2 Mar 2024

Thank you!

avatar heelc29
heelc29 - comment - 3 Mar 2024

@chmst @LadySolveig
The tooltip in the category view only applies to articles and is confusing for all other category views.
image

avatar brianteeman
brianteeman - comment - 3 Mar 2024

Confirmed that the changes in this PR are not correct - obviouslty the same problem is present with banners

avatar richard67
richard67 - comment - 3 Mar 2024

Then someone should open a new issue for it.

avatar chmst
chmst - comment - 3 Mar 2024

Thanks for merging,

@heelc29 you are correct but this is a new issue or PR.

Will open a new PR for banner clients

avatar brianteeman
brianteeman - comment - 3 Mar 2024

its not a new issue - it is caused by the changes in this pr

avatar chmst
chmst - comment - 3 Mar 2024

Sorry, was not quite awake this morning - @brianteeman and @heelc29 were correct

Please test #42944

Add a Comment

Login with GitHub to post a comment