? Language Change ? Pending

User tests: Successful: Unsuccessful:

avatar chmst
chmst
18 Sep 2022

Pull Request for Issue # .

Summary of Changes

"Configure Options Only" makes me think .. why only?

grafik

Change the String to "Configure Options"

avatar chmst chmst - open - 18 Sep 2022
avatar chmst chmst - change - 18 Sep 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 18 Sep 2022
Category Administration Language & Strings
avatar ChristineWk
ChristineWk - comment - 18 Sep 2022

I have tested this item successfully on 125143e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38781.

avatar ChristineWk ChristineWk - test_item - 18 Sep 2022 - Tested successfully
avatar brianteeman
brianteeman - comment - 18 Sep 2022

Not at my pc but please check template manager. Iirc this string comes from there where you could have access to options but not other restricted items. Unlike all other components

avatar chmst
chmst - comment - 18 Sep 2022

The string is used in permissions of the template manager. But still correct when the "only" is removed.

If core.options has another meaning in template management than in other components, we better should define an specified action.

grafik

avatar brianteeman
brianteeman - comment - 19 Sep 2022

Now that I am at my pc I can see that what was originally just a template manager permission is now everywhere and that the problem is not so much the word "only" but that there is a column missing in the users permissions view. "Configure ACL and Options"

avatar brianteeman
brianteeman - comment - 24 Sep 2022

Looking at the issue I just created #38830 I can see that the problem here arises from your pr #37807 which moved core.admin (Configure ACL and Options) out of the columns but did not also move core.options (Configure ACL Only)

In summary this is not the correct fix and it should be fixed together with #38830

avatar chmst
chmst - comment - 25 Sep 2022

Will check after my holidays. The problem occurs if no permissions are found on level >= 4.

avatar chmst
chmst - comment - 16 Oct 2022

Looking at the issue I just created #38830 I can see that the problem here arises from your pr #37807 which moved core.admin (Configure ACL and Options) out of the columns but did not also move core.options (Configure ACL Only)

In summary this is not the correct fix and it should be fixed together with #38830

#38830 is resolved with #38960. PR #37807 did not import a bug but made an old error visible.
In summary this issue has nothing to do with the above PRs.

avatar brianteeman
brianteeman - comment - 16 Oct 2022

Sorry for mistaking that error.

While I agree that in the debug user permissions view it might not be needed removing it from the permissions table does change its meaning.

image

avatar chmst
chmst - comment - 16 Oct 2022

I don't insist in changing the label, but I see a logical error in the permission rules. As a user and only from labels I think:

Configure everything | Configure options only | result

     yes         |       yes               |   configure everything but for what do we need  options only?
     yes         |       no                |   configure eeryting but don't configure options only (!)
     no          |       yes               |   configure nothing but configure options only (!)
     no          |       no                |   configure nothing but for what do we need  options only?

The follwing would be correct but must be checkd in the whole core


Configure ACL | Configure options       | result
-----------------------------------------------------------------
         yes  |       yes               | configure everything
         yes  |       no                | configure ACL only 
         no   |       yes               | configure options only
         no   |       no                | configure nothing
avatar brianteeman
brianteeman - comment - 16 Oct 2022

There isn't a configure acl only option

(maybe there should be)

avatar chmst
chmst - comment - 16 Oct 2022

This is what I wanted to demonstrate. Configure ACL and Configure Options would be better. But this is a bigger task and surely not for J4.

avatar brianteeman
brianteeman - comment - 16 Oct 2022

Agreed.

Originally the "configure options only" was a hack for joomla.com in com_templates when it was at siteground iirc

avatar chmst chmst - change - 16 Oct 2022
Title
Less is more: Configure Options
Inconsistency in permission rules - configure options only
avatar chmst chmst - edited - 16 Oct 2022
avatar Quy Quy - test_item - 19 Jan 2023 - Tested successfully
avatar Quy
Quy - comment - 19 Jan 2023

I have tested this item successfully on 125143e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38781.

avatar Quy Quy - change - 19 Jan 2023
Status Pending Ready to Commit
Labels Added: Language Change ?
avatar Quy
Quy - comment - 19 Jan 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38781.

avatar Quy Quy - change - 19 Jan 2023
Labels Added: ?
avatar roland-d roland-d - close - 20 Jan 2023
avatar roland-d roland-d - merge - 20 Jan 2023
avatar roland-d roland-d - change - 20 Jan 2023
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-01-20 08:47:53
Closed_By roland-d
avatar roland-d
roland-d - comment - 20 Jan 2023

Thank you

avatar tecpromotion
tecpromotion - comment - 21 Jan 2023

The change was unfortunately not made consistently in the API.

JACTION_OPTIONS="Configure Options Only"

PR #39682 will fix this.

Add a Comment

Login with GitHub to post a comment