User tests: Successful: Unsuccessful:
Pull Request for Issue #38737.
This PR checks if the field type being shown in the user profile is a subform.
If the field is a subform and has a fieldname set to "row", the profile thinks there is no custom field with that name. So, we must set the fieldname back to the original name of the custom field by pulling it from $field->name. (Confused yet?) Now the layout correctly finds and displays the custom field value.
See comments in issue as to why I am doing it this way instead of fixing the problem at the root. This is the only place in core where we are looking for custom field values by the fieldname instead of passing it through the field plugin to render it.
Create a user field of type text with "Onle Us In Subform"
Create a user subform field with the textfield
Create a menu item of type "user profile"
Login in frontend, edit your user and fill the subform field with at least one row.
Save your profile.
In the profile view the subform field value is missing.
In the profile view the subform field shows as expected.
None.
Status | New | ⇒ | Pending |
Category | ⇒ | Front End com_users |
Labels |
Added:
?
|
I have tested this item
Before the PR the subform values were not displayed at all. With the PR the subform values are displayed. Works as described.
I have tested this item
Test successfully! Thanks a lot for the PR!
Status | Pending | ⇒ | Ready to Commit |
RTC
Labels |
Added:
?
|
@richard67 I am not sure why the build is failing, it seems to be timing out or something.
Labels |
Added:
?
|
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-11-24 13:07:07 |
Closed_By | ⇒ | laoneo | |
Labels |
Removed:
?
|
I guess it is fine like that. Thanks for cooperation on this and following the rules.
@webgras Would you please test this PR? It fixes the issue you filed :)