? ? Pending

User tests: Successful: Unsuccessful:

avatar crystalenka
crystalenka
15 Sep 2022

Pull Request for Issue #38737.

Summary of Changes

This PR checks if the field type being shown in the user profile is a subform.

If the field is a subform and has a fieldname set to "row", the profile thinks there is no custom field with that name. So, we must set the fieldname back to the original name of the custom field by pulling it from $field->name. (Confused yet?) Now the layout correctly finds and displays the custom field value.

See comments in issue as to why I am doing it this way instead of fixing the problem at the root. This is the only place in core where we are looking for custom field values by the fieldname instead of passing it through the field plugin to render it.

Testing Instructions

Create a user field of type text with "Onle Us In Subform"
Create a user subform field with the textfield
Create a menu item of type "user profile"
Login in frontend, edit your user and fill the subform field with at least one row.
Save your profile.

Actual result BEFORE applying this Pull Request

In the profile view the subform field value is missing.
Screenshot showing user profile; the label of the subform is shown, but no value or error message.

Expected result AFTER applying this Pull Request

In the profile view the subform field shows as expected.
Screenshot showing user profile; the label of the subform is shown, as well as the values of the subform rows displayed as an unordered list.

Documentation Changes Required

None.

avatar crystalenka crystalenka - open - 15 Sep 2022
avatar crystalenka crystalenka - change - 15 Sep 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 15 Sep 2022
Category Front End com_users
avatar crystalenka crystalenka - change - 15 Sep 2022
Labels Added: ?
avatar crystalenka
crystalenka - comment - 28 Oct 2022

@webgras Would you please test this PR? It fixes the issue you filed :)

avatar nikosdion nikosdion - test_item - 20 Nov 2022 - Tested successfully
avatar nikosdion
nikosdion - comment - 20 Nov 2022

I have tested this item successfully on 96b0919

Before the PR the subform values were not displayed at all. With the PR the subform values are displayed. Works as described.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38768.

avatar webgras
webgras - comment - 21 Nov 2022

@webgras Would you please test this PR? It fixes the issue you filed :)

ah, sorry, somehow I did not see your mention. Just about to test it.

avatar webgras webgras - test_item - 21 Nov 2022 - Tested successfully
avatar webgras
webgras - comment - 21 Nov 2022

I have tested this item successfully on 96b0919

Test successfully! Thanks a lot for the PR!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38768.

avatar richard67 richard67 - change - 21 Nov 2022
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 21 Nov 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38768.

avatar crystalenka crystalenka - change - 22 Nov 2022
Labels Added: ?
avatar crystalenka
crystalenka - comment - 22 Nov 2022

@richard67 I am not sure why the build is failing, it seems to be timing out or something.

avatar crystalenka crystalenka - change - 23 Nov 2022
Labels Added: ?
avatar crystalenka
crystalenka - comment - 23 Nov 2022

@laoneo do you need me to make further changes to this? Will I need to get more tests before this goes back to RFC?

avatar laoneo laoneo - change - 24 Nov 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-11-24 13:07:07
Closed_By laoneo
Labels Removed: ?
avatar laoneo laoneo - close - 24 Nov 2022
avatar laoneo laoneo - merge - 24 Nov 2022
avatar laoneo
laoneo - comment - 24 Nov 2022

I guess it is fine like that. Thanks for cooperation on this and following the rules.

Add a Comment

Login with GitHub to post a comment