Feature Conflicting Files NPM Resource Changed PR-5.0-dev ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
14 Sep 2022

css change to make the tab character visible in the codemirror editor.
Especially useful when comparing changed files where the change is from tab to spaces

To test

either use a prebuilt package or apply pr and run build:css

go to the template manager and open a file for editing

paste the text below

This is some text with a tab 	in it.
This is some text with two tabs 		in it.

Before

image

After

image

avatar brianteeman brianteeman - open - 14 Sep 2022
avatar brianteeman brianteeman - change - 14 Sep 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 14 Sep 2022
Category Repository NPM Change
avatar brianteeman
brianteeman - comment - 15 Sep 2022

If preferred I can also add visual characters for spaces, line-breaks etc

avatar Scrabble96
Scrabble96 - comment - 16 Sep 2022

Does this PR allow for the tabs to show up in the 'differences' view?

avatar brianteeman
brianteeman - comment - 16 Sep 2022

no because that doesnt use codemirror

avatar HLeithner
HLeithner - comment - 8 May 2023

This pull request has been automatically rebased to 5.0-dev. No new features will be merged into Joomla! 4.3 series. Joomla! 4.4 series is a bridge release to make migration from Joomla! 4 to 5 as smooth as possible.

avatar brianteeman brianteeman - change - 8 May 2023
Title
[4.3] Codemirror display tabs
[5.0] Codemirror display tabs
avatar brianteeman brianteeman - edited - 8 May 2023
avatar HLeithner
HLeithner - comment - 31 Aug 2023

is this still needed for cm 6, changes are needed at least...

avatar brianteeman
brianteeman - comment - 31 Aug 2023

Probably not as this was something wanted before the new diff engine. Your call as you also expressed a desire for this.

avatar HLeithner
HLeithner - comment - 31 Aug 2023

would you rebase it, then I can merge it.

avatar brianteeman
brianteeman - comment - 31 Aug 2023

Will do

avatar brianteeman brianteeman - change - 31 Aug 2023
Labels Added: Feature Conflicting Files NPM Resource Changed PR-5.0-dev ?
avatar brianteeman
brianteeman - comment - 31 Aug 2023

Closing this as this code is not relevant for cm6

avatar brianteeman brianteeman - close - 31 Aug 2023
avatar brianteeman brianteeman - change - 31 Aug 2023
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2023-08-31 19:06:45
Closed_By brianteeman

Add a Comment

Login with GitHub to post a comment