Language Change ? Pending

User tests: Successful: Unsuccessful:

avatar N6REJ
N6REJ
14 Sep 2022

Pull Request for Issue # .

Summary of Changes

Changes "Keyboard Shortcuts" text shown at bottom of admin to "Show keyboard shortcuts"

Testing Instructions

Check bottom of admin panel showing the "Keyboard Shortcuts"
apply patch
Check that it has changed.

Actual result BEFORE applying this Pull Request

image

Expected result AFTER applying this Pull Request

image

Documentation Changes Required

if used then Update user documentation showing the change in verbiage.

avatar N6REJ N6REJ - open - 14 Sep 2022
avatar N6REJ N6REJ - change - 14 Sep 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 14 Sep 2022
Category Administration Language & Strings
avatar brianteeman
brianteeman - comment - 14 Sep 2022

Less is more - this change adds nothing

avatar N6REJ
N6REJ - comment - 14 Sep 2022

Less is more - this change adds nothing

Your welcome to your opinion.

avatar brianteeman
brianteeman - comment - 14 Sep 2022

Not just mine

github
image

gmail
image

tweetdeck
image

facebook
image

avatar N6REJ
N6REJ - comment - 14 Sep 2022

if your going to post examples the be relevant and accurate. Others ineptness at the English language is not my fault.
as FB clearly shows, their shortcut is labeled in such a way to in imply its going to a legend. They simply chose different verbiage.
image

avatar N6REJ
N6REJ - comment - 14 Sep 2022

anyway, I'm not going to continue to have a battle of wits with an unarmed opponent.

avatar N6REJ N6REJ - change - 14 Sep 2022
Labels Added: Language Change ?
avatar brianteeman
brianteeman - comment - 14 Sep 2022

if your going to post examples the be relevant and accurate. Others ineptness at the English language is not my fault.

You submitted a pull request for review and I have offered my review. You didn't provide any evidence that it is better to be overly verbose or that users have been confused about what the expected behaviour is. It is well documented that less is more when it comes to onscreen information and it's included in the style guide. Not every proposed change is an improvement and we all see contributions rejected at some time or other.

There is no need for personal attacks.

avatar mrownicki
mrownicki - comment - 15 Sep 2022

Btw.
The description of J + X is misleading. Because suggest using click together. Should be J -> X or J and X (not together).


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38755.

avatar brianteeman
brianteeman - comment - 15 Sep 2022

There is a pull request already for that

avatar jwaisner
jwaisner - comment - 16 Sep 2022

I have tested this item successfully on 203f8e4


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38755.

avatar jwaisner jwaisner - test_item - 16 Sep 2022 - Tested successfully
avatar chmst
chmst - comment - 16 Sep 2022

I like the "Show keyboard shortcuts".
But I think the headline should be only "Joomla Short Cuts"

grafik

avatar N6REJ N6REJ - change - 16 Sep 2022
The description was changed
avatar N6REJ N6REJ - edited - 16 Sep 2022
avatar brianteeman
brianteeman - comment - 16 Sep 2022

please update the original post

please use capitalisation on the title


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38755.

avatar N6REJ
N6REJ - comment - 18 Sep 2022

Everyone should be happy now. It's been redone correctly.
Sorry I made mistakes in it before.

avatar N6REJ N6REJ - change - 18 Sep 2022
The description was changed
avatar N6REJ N6REJ - edited - 18 Sep 2022
avatar N6REJ
N6REJ - comment - 18 Sep 2022

I have tested this item successfully on 203f8e4

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38755.

needs retesting due to errors on my part

avatar brianteeman
brianteeman - comment - 18 Sep 2022

I assume that you will be updating h rest of jomla with this useless extra word eg Show Help, Show Options Show Articles etc

avatar N6REJ
N6REJ - comment - 18 Sep 2022

I assume that you will be updating h rest of jomla with this useless extra word eg Show Help, Show Options Show Articles etc

Who is the one who stated personal attacks were unwarranted?

avatar brianteeman
brianteeman - comment - 19 Sep 2022

not a personal comment its a statement of fact. If we add the useless word here then we have to also add the useless word in all similar use cases.

avatar N6REJ
N6REJ - comment - 20 Sep 2022

Well, being I'm not one of the dev's who created it, when I first saw it my thoughts were...
hmmm what in the world is this?
click
OH!.. why didn't it tell me that?
so, I'm probably not the only one who feels/thinks that way.

avatar chmst
chmst - comment - 20 Sep 2022

When I first saw it, I thought that I must activate the short cuts here :D.

avatar N6REJ
N6REJ - comment - 13 Nov 2022

I give up. It's ok for others to make changes but not me.

avatar N6REJ N6REJ - close - 13 Nov 2022
avatar N6REJ N6REJ - change - 13 Nov 2022
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2022-11-13 22:32:36
Closed_By N6REJ

Add a Comment

Login with GitHub to post a comment