? ? a11y ? Pending

User tests: Successful: Unsuccessful:

avatar korenevskiy
korenevskiy
12 Sep 2022

Actual result BEFORE applying this Pull Request

Previously, the display was very restrictive. Tag links opened the tag component. But the problem is that the Tag Component does not have a mode for displaying articles as a blog. At the same time, the display of the list of materials of one tag must be made additional layout.

Expected result AFTER applying this Pull Request

The new module allows you to display tags in the form of a tree, This will allow you to use tags to display as a catalog of categories. Every developer faces a problem when an article needs to be placed in 2(3) different categories at once. For example, an article can simultaneously contain future news, as well as an article can contain information about the PHP language, as well as contain information about gifts. By opening the module tag link, a list of blog materials will be displayed.

While deleting the material tag, the material link remains the same. But if we moved an article from one category to another, the article link would change. Now the article link will remain the same, and tags can be used instead of categories.

image

UPDATED DESCRIPTION
A known problem.
After clicking on the tag links, the Category, Blog component stores this tag in the cache, and later, when opening any Category and Blog links, materials with the last open tag will be displayed.

A quick solution to the problem.
In the link settings in the component menu, in the tag selection field, you must specify the selection of an empty tag. This will allow you to open links by resetting the tag filter in the cache.

The required Solution to the problem.
It is required to make changes to the code of the Category and Blog component so that links without the selected tag reset the tag filter in the cache.

avatar korenevskiy korenevskiy - open - 12 Sep 2022
avatar korenevskiy korenevskiy - change - 12 Sep 2022
Status New Pending
avatar korenevskiy korenevskiy - change - 12 Sep 2022
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 12 Sep 2022
Category Administration com_fields Modules Front End
avatar korenevskiy korenevskiy - change - 12 Sep 2022
The description was changed
avatar korenevskiy korenevskiy - edited - 12 Sep 2022
avatar brianteeman
brianteeman - comment - 12 Sep 2022

you dont need to include the russian language files

avatar brianteeman
brianteeman - comment - 12 Sep 2022

and is the file translate.php part of this module?

avatar korenevskiy
korenevskiy - comment - 12 Sep 2022

and is the file translate.php part of this module?

No. I deleted this file.

avatar joomla-cms-bot joomla-cms-bot - change - 12 Sep 2022
Category Administration com_fields Modules Front End Administration com_fields Language & Strings Modules Front End
avatar korenevskiy korenevskiy - change - 12 Sep 2022
Labels Added: Language Change
avatar korenevskiy korenevskiy - change - 12 Sep 2022
The description was changed
avatar korenevskiy korenevskiy - edited - 12 Sep 2022
avatar joomla-cms-bot joomla-cms-bot - change - 12 Sep 2022
Category Administration com_fields Modules Front End Language & Strings Language & Strings Modules Front End
avatar korenevskiy
korenevskiy - comment - 12 Sep 2022

Please help. Save me. I am correcting errors, but the validator shows imaginary errors. I have already deleted spaces and hyphenations, and then did it again, but errors remain.

Help me fix the errors!!!!!

avatar alikon
alikon - comment - 12 Sep 2022

if you look at https://ci.joomla.org/joomla/joomla-cms/57815/1/6 there is a detailed report on what drone complain about CS
image

hope that helps

imho shouldn't be a core but a 3dp module

avatar korenevskiy
korenevskiy - comment - 12 Sep 2022

@alikon
Yes, I have been looking into this report from the very beginning. I have already removed 80% of the errors.
But I can't fix the remaining errors. You will see for yourself the code and the error in the report. I do not understand that there is an error in an empty place.
After that, I correct the errors as indicated in the report, and in the new report the requirement to remove the added space back. Ie, first the report asks to add a space, and in the next report asks to remove the space back.

Maybe I don't understand something?

avatar brianteeman
brianteeman - comment - 12 Sep 2022

I would suggest not to worry for now about code style and first to get people to check what the module does and if it is something for core. (there are lots of other style issues that drone didnt find)

avatar alikon
alikon - comment - 12 Sep 2022

joomla recently switched from own cosdestyle to PSR-12 https://www.php-fig.org/psr/psr-12/
so maybe this is the main source of confusion
i've made a silly pr to your branch to fix only the 1st drone report
check it maybe it will let you to reduce the cs complains

avatar korenevskiy
korenevskiy - comment - 12 Sep 2022

so maybe this is the main source of confusion

@alikon
You're right, the problem was in the curly brace after the condition. But in the error report, it is NOT stated that the problem is curly brace. The report just says about the brace. And since the curly brace is on another line, that implies a parenthesis, as well as the error is indicated in the absence of a space. The error in the report does not indicate the cause of the error at all.

Thank you for your help, now I will know about the new code format.

avatar korenevskiy
korenevskiy - comment - 12 Sep 2022

modules/mod_category_tags/tmpl/_childs.php (line 1)
@alikon
I have fixed all the errors, there is one more error that I cannot remove. Please help me fix it. The parser swears that the line break "\r\n" is used instead of "\n". No matter how much I would try to fix the transfer, the error remains in the code.

avatar richard67
richard67 - comment - 12 Sep 2022

@korenevskiy Regarding naming of files and variables: The plural of "child" in English language is "children", not "childs".

avatar richard67
richard67 - comment - 12 Sep 2022

modules/mod_category_tags/tmpl/_childs.php (line 1) @alikon I have fixed all the errors, there is one more error that I cannot remove. Please help me fix it. The parser swears that the line break "\r\n" is used instead of "\n". No matter how much I would try to fix the transfer, the error remains in the code.

@korenevskiy You could use a good editor like notepad++ which can show you what kind of line feeds are in the file (Unix like it should be, or Windows like the PHP CS check complains about).

avatar korenevskiy korenevskiy - change - 12 Sep 2022
Labels Added: a11y
avatar korenevskiy korenevskiy - change - 12 Sep 2022
Labels Added: ?
avatar Kostelano
Kostelano - comment - 13 Sep 2022

By the way, replace the branch with 4.3.

avatar joomla-cms-bot joomla-cms-bot - change - 13 Sep 2022
Category Modules Front End Language & Strings Unit Tests Repository Administration com_associations com_banners com_categories com_config com_contact com_content com_contenthistory com_fields com_finder com_installer com_joomlaupdate com_languages com_menus
avatar korenevskiy korenevskiy - change - 13 Sep 2022
Labels Added: ?
Removed: Language Change
avatar korenevskiy
korenevskiy - comment - 13 Sep 2022

Dear colleagues. I have created a new PR for branch 4.3. I am not able to transfer PR to a new branch. I decided to create anew. Here's a new PR #38752

@brianteeman , @Kostelano , @chmst , @alikon , @richard67 , @laoneo , @rdeutz , @Hackwar , @wilsonge , @zero-24 , @bembelimen , @joomdonation , @obuisard , @HLeithner , @heelc29 , @sonvnn @webuniverse @viocassel

avatar korenevskiy korenevskiy - change - 13 Sep 2022
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2022-09-13 19:29:14
Closed_By korenevskiy
avatar korenevskiy korenevskiy - close - 13 Sep 2022

Add a Comment

Login with GitHub to post a comment