Feeling Lucky
?
[#3874] - [#33937] Make JFTP more easily extensible
- Closed
- 3 Aug 2014
- Medium
- Build: staging
- # 3874
- Diff
- okonomiyaki3000:jftp-more-extensible
- Foreign ID 33937
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Make class properties protected instead of private so that they can be used by subclasses. Access with static:: rather than self:: so that subclasses can maintain their own instances.
| Title |
|
||||||
okonomiyaki3000
- comment
- 25 Jul 2014
Hmm. This is not something that's so easy to test but before applying this patch, FTP works. After, FTP still works. Nothing should change. The change here just makes it easier to write subclasses of JFTP. So maybe you can test it by trying to write one?
mbabker
- | Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-08-03 16:21:32 |
From a code-review perspective, makes full sense.