? ? Pending

User tests: Successful: Unsuccessful:

avatar richard67
richard67
11 Sep 2022

Pull Request for Issue # .

Summary of Changes

The only two modules "mod_articles_latest" and "mod_articles_news" which have been refactored to the new services structure have a doc block tag @package Joomla.Administrator in their "provider.php" files.

This is possibly a remainder from copying from previously refactored administrator modules.

It should be @package Joomla.Site like for all other PHP files of site modules.

This pull request (PR) fixes that.

Testing Instructions

Check the @package doc block tag of all PHP files below the "modules" folder, i.e. of all site modules.

On Windows you can use following commands in a Windows Command Shell (CMD):

cd modules
findstr /s /i /c:"@package" *.php

On Linux and similar you can use following commands in a command shell (e.g. bash):

find ./modules -type f -name "*\.php" -exec grep -iH "@package" {} \;

Actual result BEFORE applying this Pull Request

All PHP files of site modules have @package Joomla.Site except of the two files modified by this PR, those have @package Joomla.Administrator

Expected result AFTER applying this Pull Request

All PHP files of site modules have @package Joomla.Site.

Documentation Changes Required

None.

avatar richard67 richard67 - open - 11 Sep 2022
avatar richard67 richard67 - change - 11 Sep 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 11 Sep 2022
Category Modules Front End
avatar brianteeman
brianteeman - comment - 11 Sep 2022

I have tested this item successfully on 622b352


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38738.

avatar brianteeman brianteeman - test_item - 11 Sep 2022 - Tested successfully
avatar chmst
chmst - comment - 11 Sep 2022

I have tested this item successfully on 622b352


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38738.

avatar chmst chmst - test_item - 11 Sep 2022 - Tested successfully
avatar chmst chmst - change - 11 Sep 2022
Status Pending Ready to Commit
avatar chmst
chmst - comment - 11 Sep 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38738.

avatar laoneo laoneo - change - 12 Sep 2022
Labels Added: ? ?
avatar laoneo laoneo - close - 12 Sep 2022
avatar laoneo laoneo - merge - 12 Sep 2022
avatar laoneo laoneo - change - 12 Sep 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-09-12 07:17:21
Closed_By laoneo
avatar laoneo
laoneo - comment - 12 Sep 2022

Thanks!

Add a Comment

Login with GitHub to post a comment