Language Change ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
6 Sep 2022

oops missed updating these two files to use the html entity instead of the three dots

see #38638

avatar brianteeman brianteeman - open - 6 Sep 2022
avatar brianteeman brianteeman - change - 6 Sep 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 6 Sep 2022
Category Administration Language & Strings
avatar toivo
toivo - comment - 7 Sep 2022

I have tested this item successfully on 114db67


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38710.

avatar toivo toivo - test_item - 7 Sep 2022 - Tested successfully
avatar viocassel
viocassel - comment - 7 Sep 2022

I have tested this item successfully on 114db67


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38710.

avatar viocassel viocassel - test_item - 7 Sep 2022 - Tested successfully
avatar Abernyte-Git
Abernyte-Git - comment - 7 Sep 2022

I have tested this item successfully on 114db67


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38710.

avatar Abernyte-Git Abernyte-Git - test_item - 7 Sep 2022 - Tested successfully
avatar HLeithner
HLeithner - comment - 7 Sep 2022

as commented in the other pr can we please use the proper utf8 character and not the html encoded string.

avatar brianteeman
brianteeman - comment - 7 Sep 2022

No I will not change it and we have plenty of html in our strings.

&hellip is easier to type and visually an editor will not mistakenly type ... when they mean …

As already explained we must use an ellipsis for accessibility and changing to use the utf8 … from the ... will not help as translators etc will not SEE that they are different and will continue to type ... especially as its much easier to type ... than it is to look up the utf8 character. It's certainly easier for me to type &hellip than it is to open a character map and locate the utf8 map and then locate the ellipsis and insert it into a document

avatar Razzo1987
Razzo1987 - comment - 7 Sep 2022

I have tested this item successfully on 114db67


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38710.

avatar Razzo1987 Razzo1987 - test_item - 7 Sep 2022 - Tested successfully
avatar infograf768
infograf768 - comment - 7 Sep 2022

The problem using the web ellipsis character (UTF8 or hellip;) instead of 3 periods is the space between the dots. It entirely depends on the font used. In some cases the ellipsis is hardly readable.

Example:

Screenshot 2022-09-07 at 10 50 59

avatar brianteeman
brianteeman - comment - 7 Sep 2022

using three individual dots is simply wrong

avatar Razzo1987
Razzo1987 - comment - 7 Sep 2022

3 dot, utf8 or ellipsis?

How does a screen reader behave for blind users?
I don't know the answer, but I think it might help us figure out what not to use.

avatar brianteeman
brianteeman - comment - 7 Sep 2022

I don't know the answer, but I think it might help us figure out what not to use.

I already did the research ;)

Sadly there is no uniform answer for all screen readers and it also depends what mode they are in.

https://bighack.org/accessibility-screen-readers-special-characters-and-unicode-symbols/

https://tosbourn.com/the-importance-of-using-the-ellipsis-character/

https://www.deque.com/blog/dont-screen-readers-read-whats-screen-part-1-punctuation-typographic-symbols/#typo

avatar infograf768
infograf768 - comment - 7 Sep 2022

Anyhow, the patch is wrong in English as there is no obvious breaking space before the ellipsis. This lets that ellipsis to be pushed to next line if no space enough for the phrase to display in the available box.
I guess the patch should rather be  …

we get with the patch as is
Screenshot 2022-09-07 at 11 32 29

instead of what it should be:

Screenshot 2022-09-07 at 11 34 34

(In French we do not have the issue as there is no space before the ellipsis —or 3 dots as multiple dots don't break—)

avatar brianteeman
brianteeman - comment - 7 Sep 2022

sorry JM the english is fine

avatar brianteeman
brianteeman - comment - 7 Sep 2022

no one is forced to merge this

avatar N6REJ
N6REJ - comment - 8 Sep 2022

@brianteeman stop being defensive. JM brings up a valid point. it's clearly NOT fine in english

avatar N6REJ
N6REJ - comment - 8 Sep 2022

@chmst can the accessibility team give some feedback?

avatar brianteeman
brianteeman - comment - 8 Sep 2022

@N6REJ please educate me with real world examples of the strings chanhged in this PR how it is ever wrong in english and please provide documented evidence of that

avatar N6REJ
N6REJ - comment - 9 Sep 2022

he's not talking about the string he's talking about the string behavior and THAT as he showed is currently wrong which was the OP point

avatar brianteeman
brianteeman - comment - 9 Sep 2022

Never mind. Ignore what I said if you want. Merge or reject - not my call

avatar brianteeman brianteeman - change - 19 Sep 2022
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2022-09-19 08:48:50
Closed_By brianteeman
Labels Added: Language Change ?
avatar brianteeman brianteeman - close - 19 Sep 2022

Add a Comment

Login with GitHub to post a comment