Feeling Lucky
?
[#3869] - [#33932] SQL schemas updates are not applied if previous component version didn't have schemas declaration
- Closed
- 7 Aug 2014
- Medium
- Build: staging
- # 3869
- Diff
- Denitz:33932
- Foreign ID 33932
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
| Title |
|
||||||
Denitz
- comment
- 11 Jul 2014
I guess we will never get empty version in #__schema, but I agree with you.
Updated.
Bakual
- comment
- 11 Jul 2014
I actually produced an empty string by installing an extension with the update schemas defined in the manifest but without the actual folder present. 
Thanks for the change. it worked for me so far.
brianteeman
- | Labels |
Added:
?
|
||
infograf768
- comment
- 4 Aug 2014
We need a 2.5.x similar PR
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-08-07 19:33:55 |
Sophist-UK
-
I like this change. However I wonder why you explicitely check for
if ($version === null). Wouldn't it make more sense to check usingif (!$version), detecting for example also an empty string?