Feeling Lucky
?
?
[#38669] - Duplicated code
- Fixed in Code Base
- 6 Sep 2022
- Medium
- Build: 4.2-dev
- # 38669
- Diff
- brianteeman:menu_item
User tests: Successful: Unsuccessful:
This PR removes a block of duplicated code. They two blocks are slightly different as the home is in a different place. But as the first block is overridden by the second block I have deleted the first block.
There is no visible changes as a result of this PR. Either test by code review or by checking that you can still create and edit menu items exactly the same as before this PR
(any comments about codestyle will be ignored as out of scope for this pr)
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_menus |
toivo
- comment
- 5 Sep 2022
I have tested this item
Tested successfully in Joomla 4.2.3-dev of 5 September in Wampserver 3.2.9 and PHP 8.1.9.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38669.
| Status | Pending | ⇒ | Ready to Commit |
alikon
- comment
- 5 Sep 2022
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38669.
Quy
- | Labels |
Added:
?
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-09-06 10:25:52 |
| Closed_By | ⇒ | wilsonge |
wilsonge
- comment
- 6 Sep 2022
Thanks!
brianteeman
- comment
- 6 Sep 2022
thanks
I have tested this item✅ successfully on 4a48516
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38669.