[#3866] - Corrected switch to SSL URI
- Closed
- 17 Dec 2015
- Medium
- Build: staging
- # 3866
- Diff
- piotrmocko:patch-19
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
When you enter page with SSL and there is a form, then this form should also have SSL URI.
In current JRoute it was intend to do so, but there is a mistake.
To check if current page is SSL we need to do it on current page URI instance, instead on URI which we are building.
There is not need to store host and port in static variable as now current URI instance is being got always.
Also variable $ssl should be forced to INT in all parts of code,
as it is being passed as string from module parameters, e.g. in mod_login
| Description | <p>To check if current page is SSL we need to do it on current page URI instance, instead on URI which we are building.<br> There is not need to store host and port in static variable as now current URI instance is being got always.</p> | ⇒ | <p>When you enter page with SSL and there is a form, then this form should also have SSL URI.<br> In current JRoute it was intend to do so, but there is a mistake.<br> To check if current page is SSL we need to do it on current page URI instance, instead on URI which we are building.</p> <p>There is not need to store host and port in static variable as now current URI instance is being got always.</p> <p>Also variable $ssl should be forced to INT in all parts of code, <br> as it is being passed as string from module parameters, e.g. in mod_login</p> |
| Labels |
Added:
?
?
|
||
There is a discussion on JoomlaCode Tracker to consider removing checking if current page is SSL, because if current page is SSL then relative link would work correct and we do not need to change it to absolute URI with HTTPS.
+1 works for me.
| Status | New | ⇒ | Pending |
nicksavov
- | Labels |
Removed:
?
|
||
| Category | ⇒ | Libraries |
Problem doesn't exist anymore tested with firebug link is know HTTPS.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/3866.
Hello @piotrmocko
Thank you for your contribution.
The last comment here was on 21st August. So the question is, Is this issue/pull request still valid?
if so please provide clear test instructions to be able to test / reproduce this issue.
If no reply is received within 4 weeks we will close this issue.
Thanks for understanding!
| Status | Pending | ⇒ | Information Required |
| Status | Information Required | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-12-17 11:10:41 |
| Closed_By | ⇒ | brianteeman |
Closed due to lack of response for further information - it can always be reopened if that is provided
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/3866.
JoomlaCode Tracker
http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=33933