github and gmail both use the same type of sequential shortcut key

github just shows the two letter eg J X
gmail uses a then eg J then X

I like the approach with "then"
"+" is misleading and not writing anything is not clear enough i think

Should I create a PR with then instead of + or does something speak against it?

BTW, in Joomla 4.2.1 shortcuts only upper case letters work, as I found out by trial and error. That is probably a good thing, as long as it is clearly documented, at least in the Help section of the Keyboard Shortcuts plugin,

Should I create a PR with then instead of + or does something speak against it?

Yes, please do so

BTW, in Joomla 4.2.1 shortcuts only upper case letters work, as I found out by trial and error. That is probably a good thing, as long as it is clearly documented, at least in the Help section of the Keyboard Shortcuts plugin,

no they work in both upper and lower case

True, further test confirms they work. My first test results from PEBCAK.

I just prepare the PR but the language Change in the administrator/language/en-GB/plg_system_shortcut.ini and administrator/language/en-GB/plg_system_shortcut.sys.ini have no effect on the information in the modal window. Searching through the whole Project I only found a es6 File where the Keyboards are mentioned. Are they hardcoded there? @fancyFranci ?

@richard67 thats the correct place. So you can either go the github option and remove the + in the js
or create a language string
in the php pass it to the script
and then use it in the script

@richard67 thats the correct place. So you can either go the github option and remove the + in the js or create a language string in the php pass it to the script and then use it in the script

@brianteeman Hmm, as far as I can see, the '+' at the place which I've found is used to separate the particular keys. But where does the + in the modal display come from?

Sorry I am getting really confused here (for a change)

The Keyboard Shortcuts are announced everywhere with J + X

where? Thats not what I am seeing

I trusted the desription in the issue. I haven't checked the modal myself because I'm in the office at my regular job. But I'm confused now, too.

On dashboard, scroll down

Ah there it is.

I like the idea about replacing + to then, also would do it in modal popup

@Fedik that string is a 30 second change

I replaced it there but I see no change. I can upload the PR anyway.

@coolcat-creations On a quick search I found a hard-coded usage of '+' as separator for keys: https://github.com/joomla/joomla-cms/blob/4.2-dev/build/media_source/plg_system_shortcut/js/shortcut.es6.js#L106

I know, that was not what you are looking for. But I thought I should mention it because you might have to change that, too.

thats what I meant in my previous post

@Fedik that string is a 30 second change

joomla-cms/administrator/language/en-GB/plg_system_shortcut.ini

Line 8 in c9331a8

PLG_SYSTEM_SHORTCUT_OVERVIEW_HINT="<span class=\"icon-keyboard fa-keyboard me-2\" aria-hidden=\"true\"></span> <kbd>J</kbd> + <kbd>X</kbd> <small>Keyboard Shortcuts</small>"

But the PLG_SYSTEM_SHORTCUT_XML_DESCRIPTION does not have any effect on the modal

the modal doesnt have the + you were complaining about in your first post

Yes, it does not have the "then" as well, I wanted to change it there too.

Closing, because we have a PR #38667
Please test