? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
30 Aug 2022

There were two bugs

  1. The dropdown scripts was only being loaded on a split button - it was needed for both
  2. Instead of using the htmlhelper it should have been using trhe web asset manager

To test disable the User Status Module and apply this pr

Go to any list view and check that the actions dropdown works as expected

Pull Request for Issue #38640

avatar brianteeman brianteeman - open - 30 Aug 2022
avatar brianteeman brianteeman - change - 30 Aug 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 30 Aug 2022
Category Administration com_languages com_media Layout Modules Front End
avatar Abernyte-Git
Abernyte-Git - comment - 30 Aug 2022

I have tested this item successfully on fa0849e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38644.

avatar Abernyte-Git Abernyte-Git - test_item - 30 Aug 2022 - Tested successfully
avatar chmst
chmst - comment - 30 Aug 2022

Seems that there are more files in the PR than needed?

avatar brianteeman brianteeman - change - 30 Aug 2022
Labels Added: ?
avatar brianteeman
brianteeman - comment - 30 Aug 2022

Seems that there are more files in the PR than needed?

fixed

avatar joomla-cms-bot joomla-cms-bot - change - 30 Aug 2022
Category Administration com_languages com_media Layout Modules Front End Layout
avatar alikon
alikon - comment - 31 Aug 2022

I have tested this item successfully on 16bcfe0


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38644.

avatar alikon alikon - test_item - 31 Aug 2022 - Tested successfully
avatar viocassel
viocassel - comment - 31 Aug 2022

I have tested this item successfully on 16bcfe0


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38644.

avatar viocassel viocassel - test_item - 31 Aug 2022 - Tested successfully
avatar alikon alikon - change - 31 Aug 2022
Status Pending Ready to Commit
avatar alikon
alikon - comment - 31 Aug 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38644.

avatar bembelimen bembelimen - change - 31 Aug 2022
Title
Actions Dropdown
[4.2] Actions Dropdown
avatar bembelimen bembelimen - edited - 31 Aug 2022
avatar wilsonge wilsonge - change - 5 Sep 2022
Labels Added: ?
avatar wilsonge
wilsonge - comment - 5 Sep 2022

OK This one wasn't intuitive to me - had to dig back through the comments on the previous issue - added a code comment with reasoning to help stop it being reverted accidentally in the future. RTC is still valid

avatar wilsonge wilsonge - change - 5 Sep 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-09-05 11:03:51
Closed_By wilsonge
avatar wilsonge wilsonge - close - 5 Sep 2022
avatar wilsonge wilsonge - merge - 5 Sep 2022
avatar brianteeman
brianteeman - comment - 5 Sep 2022

thanks

Add a Comment

Login with GitHub to post a comment