? Language Change ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
30 Aug 2022

Following the style guide and accessibility recommendations this PR changes the use of ... (dot dot dot) to the html entity for an ellipsis.

For example some screenreaders will announce the three dots eg read more dot dot dot but with an ellipsis they pause and do not say dot dot dot

This PR is only for the language strings. A further PR will follow to address truncation

PARTIAL Pull Request for Issue #38630

avatar brianteeman brianteeman - open - 30 Aug 2022
avatar brianteeman brianteeman - change - 30 Aug 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 30 Aug 2022
Category Administration Language & Strings Installation
avatar brianteeman brianteeman - change - 30 Aug 2022
Labels Added: Language Change ?
avatar brianteeman
brianteeman - comment - 30 Aug 2022

Maybe this should be separated. Already hyphenated and lowercase elsewhere.

Sorry I dont understand what you are saying - maybe I need more coffee

avatar tecpromotion
tecpromotion - comment - 30 Aug 2022

I have tested this item successfully on 56ac93c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38638.

avatar tecpromotion tecpromotion - test_item - 30 Aug 2022 - Tested successfully
avatar N6REJ
N6REJ - comment - 30 Aug 2022

@brianteeman docs will need to be updated as it specifically states "three periods"

avatar Quy
Quy - comment - 30 Aug 2022

I have tested this item successfully on 56ac93c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38638.

avatar Quy Quy - change - 30 Aug 2022
Status Pending Ready to Commit
avatar Quy
Quy - comment - 30 Aug 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38638.

avatar Quy Quy - test_item - 30 Aug 2022 - Tested successfully
avatar N6REJ
N6REJ - comment - 31 Aug 2022

@brianteeman https://developer.joomla.org/en-gb-user-interface-text-guidelines/punctuation.html

An ellipsis is a set of three periods ( ... ) indicating an omission. The group of periods should have a single space on either side. Unless it is at the end of a string where there is no space or period after.
Example

Read more ...
Create some text ... add some pictures.

Notice it says "three periods"

avatar brianteeman
brianteeman - comment - 31 Aug 2022

@N6REJ thanks - the docs have been updated just waiting for a merge

avatar roland-d roland-d - change - 31 Aug 2022
Labels Added: ?
avatar roland-d roland-d - change - 31 Aug 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-08-31 20:34:39
Closed_By roland-d
avatar roland-d roland-d - close - 31 Aug 2022
avatar roland-d roland-d - merge - 31 Aug 2022
avatar roland-d
roland-d - comment - 31 Aug 2022

Thank you

avatar brianteeman
brianteeman - comment - 31 Aug 2022

thanks

avatar Razzo1987
Razzo1987 - comment - 6 Sep 2022

Also in

COM_MEDIA_SEARCH="Search..."

and
PLG_TASK_CHECK_FILES_LOG_RESIZE_FAIL="Failed to resize image due to an error in plugin logic..."

avatar brianteeman
brianteeman - comment - 6 Sep 2022

@Razzo1987 thanks - see #38710

avatar HLeithner
HLeithner - comment - 7 Sep 2022

What's the reason why you use the html encoding & hellip ; instead of the utf8 character … ?

avatar brianteeman
brianteeman - comment - 7 Sep 2022

Clarity.

avatar HLeithner
HLeithner - comment - 7 Sep 2022

can we please change this because this would not work in cli script or non-browser context, afaik is that we try to avoid html encoding in language files and use utf8 directly (it's done for easy writing)

avatar brianteeman
brianteeman - comment - 7 Sep 2022

No I will not change it and we have plenty of html in our strings.

&hellip is easier to type and visually an editor will not mistakenly type ... when they mean …

As already explained we must use an ellipsis for accessibility and changing to use the utf8 … from the ... will not help as translators etc will not SEE that they are different and will continue to type ... especially as its much easier to type ... than it is to look up the utf8 character. It's certainly easier for me to type &hellip than it is to open a character map and locate the utf8 map and then locate the ellipsis and insert it into a document

avatar brianteeman
brianteeman - comment - 7 Sep 2022

image

which of those is the real ellipsis

avatar HLeithner
HLeithner - comment - 7 Sep 2022

That one which also works outside of a webbrowser.

avatar HLeithner
HLeithner - comment - 7 Sep 2022

OK so the Unicode consortium are all idiots and we should go back to ascii and HTML encoding. Makes sense to me.

avatar HLeithner
HLeithner - comment - 7 Sep 2022

forget the "idiots", I already argument like other people in this tracker and that makes it sick. People are doing anyway what they want to do so I should not take this personally and look at my health.

avatar brianteeman
brianteeman - comment - 7 Sep 2022

I know many of the unicode consortium, spoken at their conference twice, nice people. However, unfortunately, much of their work is not accessible at all or more accurately is misused and is therefore not accessible and we have no control/influence on how the different screen reader applications work. - they're all different to each other most of the time.

avatar brianteeman
brianteeman - comment - 7 Sep 2022

No one was forced to merge this

avatar N6REJ
N6REJ - comment - 8 Sep 2022

is it possible to add the … to tiny as I'm darn sure never going to remember that and I use ... almost hourly

avatar brianteeman
brianteeman - comment - 8 Sep 2022

What does that have to do with changing language strings?

Add a Comment

Login with GitHub to post a comment