[#38632] - [4.2] fix shortcut Home Dashboard
- Fixed in Code Base
- 2 Sep 2022
- Medium
- Build: 4.2-dev
- # 38632
- Diff
- tecpromotion:fix-shortcut-jhomedashboard
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Summary of Changes
The string JHOMEDASHBOARD="Home Dashboard" was added and the call in shortcut.php was adjusted.
Testing Instructions
Move to different views in the backend and press the key combination J+X.
Actual result BEFORE applying this Pull Request
J+D is only translated if com_cpanel.ini is also loaded. However, this is not always the case in the backend.
J+X displays the correct value "Home Dashboard" for J+D when calling /administrator/index.php.
For example, when calling /administrator/index.php?option=com_content&view=article, it will not be translated.
Expected result AFTER applying this Pull Request
J+D is always translated.
Documentation Changes Required
.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings Front End Plugins |
Hard for me to test as I cant replicate the problem but the changes make sense
@brianteeman just go to https://yourdomain.tld/administrator/index.php?option=com_content&view=article and press J+X
With Debug Language on:
I have tested this item
I tested this in J4.2 with php 8.1., language string for shortcut description "J+D" is translated now.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38632.
Don't know what to say but it works like this for me without this pr. But the pr still looks good and it probably should have been created your way in the first place.
Don't know what to say but it works like this for me without this pr. But the pr still looks good and it probably should have been created your way in the first place.
In 4.2.1-rc2 ?
Don't know what to say but it works like this for me without this pr. But the pr still looks good and it probably should have been created your way in the first place.
it is only broken in the dashboard views, like com_contact Dashboard or com_users Dashboard with J+X ~~
i.E. /administrator/index.php?option=com_users&view=users
sorry, my wrong. For me, it is also broken in the edit views (in 4.2.0)
And german
Very strange - the string is translated without PR,
online and local.
with and without debug mode
on dashboards, in edit and on list views.
PHP 8.1.6
edit: after upgrade, not fresh installation
I was able to reproduce it and will validate this tomorrow.
- Install a fresh 4.2.0-rc2 or update from 4.1.5
- click J+X on Dashboard or anything else - J+D is always translated
- click on "Post Installation Messages" and hide all messages
- go to dashboard and click J+X - it's working
- click anything else - J+D is not translated
- click on "Post Installation Messages" and reset all messages
- click J+X on Dashboard or anything else - J+D is always translated again!
small video
https://capture.dropbox.com/embed/h1jAJb6IUUKjOkuX
Bingo - I can now replicate this with your instructions.
The problem exists on any emptystate page.
I think it would be better to find out why that happens than to change the string. This might end up just being a band aid to a bigger problem
very weird I now see the problem on every page
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38632.
| Labels |
Added:
Language Change
?
|
||
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-09-02 19:11:35 |
| Closed_By | ⇒ | roland-d |
Thank you
Hard for me to test as I cant replicate the problem but the changes make sense