Feeling Lucky
?
[#3863] - Add return value
- Closed
- 9 Jul 2014
- Medium
- Build: staging
- # 3863
- Diff
- genu:patch-1
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Function should return the $result of the access level check
genu
- comment
- 9 Jul 2014
Not sure if the save() should have a return value... :/. Could it just return true since it seem to have many other validation checks that return false?
Bakual
- comment
- 9 Jul 2014
I agree the save one should return true at the end of the method (after the switch statement). At this stage, the save was successful already.
bcordis
- comment
- 9 Jul 2014
Make sure to create a tracker item and add link here.
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-07-09 18:56:43 |
Bakual
- comment
- 9 Jul 2014
Merged from code review. Thanks.
I think it would make sense to change the return value for the edit method as well.
Currently it returns always true, but it should atually return
$resultas well.