Feeling Lucky
?
?
[#38629] - [4.2] Initialize the installer script variable correctly
- Fixed in Code Base
- 15 Sep 2022
- Medium
- Build: 4.2-dev
- # 38629
- Diff
- Digital-Peak:installer/script-init
User tests: Successful: Unsuccessful:
Summary of Changes
#37091 adds the possibility for extensions to deliver the installer script differently than by a predefined class name. Pr #37374 broke that while adding a deprecated notice. This pr correctly instantiates the installer variable.
Testing Instructions
- Install the container based script mod_installer_container.zip
- Install the script based script mod_installer_script.zip
- Install the legacy script mod_installer_legacy.zip
Actual result BEFORE applying this Pull Request
- The container module shows no text "Installed by container!!"
- The container module shows no text "Installed by script!!"
- The container module shows text "Installed by legacy!!"
Expected result AFTER applying this Pull Request
- The container module shows text "Installed by container!!"
- The container module shows text "Installed by script!!"
- The container module shows text "Installed by legacy!!"
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
?
|
||
viocassel
- comment
- 14 Sep 2022
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38629.
| Status | Pending | ⇒ | Ready to Commit |
alikon
- comment
- 14 Sep 2022
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38629.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-09-15 21:09:00 |
| Closed_By | ⇒ | fancyFranci |
fancyFranci
- comment
- 15 Sep 2022
Nice fix, thank you!
I have tested this item✅ successfully on 9aba88a
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38629.
Before:
after:
