[#38626] - Language Override space
- Fixed in Code Base
- 30 Sep 2022
- Medium
- Build: 4.2-dev
- # 38626
- Diff
- brianteeman:override
User tests: Successful: Unsuccessful:
When you have a language override that is in both locations then it is displayed as site /administrator
This extra space is added because the markup is on multiple lines.
To Test
Go to language overrides and select a language-admin pair
Create a new override and check the box for both locations
Save and check the list of overrides
Before
After
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_languages |
| Labels |
Added:
?
|
||
@HLeithner my reading of the drone error is that its not possible to resolve the space issue that the pr is intended to do without breaking the cs rules. Your advice please
@brianteeman Does it work without the curly brackets?
Thank @HLeithner all good now
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38626.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38626.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38626.
Should we not try to avoid multi line PHP statements in layout files? If I remember correctly every PHP code in these layout files should start with <?php. To solve this issue you can make a one line statement out of it:
<?php echo $client . (isset($oppositeStrings[$key]) && $oppositeStrings[$key] === $text ? '/' . $oppositeClient : ''); ?>
is it in the code styles?
... and I would say it is beyond the scope of this PR as it was already on multiple lines that did not begin and end with <?
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-09-30 14:46:37 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
?
|
||
thanks
thx
@HLeithner my reading of the drone error is that its not possible to resolve the space issue that the pr is intended to do without breaking the cs rules. Your advice please