? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
26 Aug 2022

Pull Request for Issue #27407.

Summary of Changes

Moves the captcha to the end of the form.

Testing Instructions

  1. Enable recaptcha
  2. set the captcha in global config
  3. create a contact
  4. create custom contact fields for mails
  5. check the contact form on the front end - captcha displayed
  6. disable captcha in global config
  7. check the contact form on the front end - no captcha displayed
  8. enable captcha in the contact component
  9. check the contact form on the front end - captcha displayed

Actual result BEFORE applying this Pull Request

the captcha is rendered after the default fields but before any custom fields

Expected result AFTER applying this Pull Request

the captcha is rendered at the end of the form

avatar brianteeman brianteeman - open - 26 Aug 2022
avatar brianteeman brianteeman - change - 26 Aug 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 26 Aug 2022
Category Front End com_contact
avatar chmst
chmst - comment - 26 Aug 2022

A second loop over fieldsets is not necessary if you use a variable.

avatar brianteeman
brianteeman - comment - 26 Aug 2022

@chmst I tried and failed. maybe my brain is still not fully functional. pr to my branches are welcome

avatar chmst chmst - change - 26 Aug 2022
Labels Added: ?
avatar obuisard
obuisard - comment - 26 Aug 2022

I have tested this item successfully on 901a8ec

Perfect


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38607.

avatar obuisard obuisard - test_item - 26 Aug 2022 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 26 Aug 2022

I have tested this item successfully on 901a8ec


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38607.

avatar ChristineWk ChristineWk - test_item - 26 Aug 2022 - Tested successfully
avatar Quy Quy - change - 26 Aug 2022
Status Pending Ready to Commit
avatar Quy
Quy - comment - 26 Aug 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38607.

avatar wilsonge wilsonge - change - 5 Sep 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-09-05 10:44:56
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 5 Sep 2022
avatar wilsonge wilsonge - merge - 5 Sep 2022
avatar wilsonge
wilsonge - comment - 5 Sep 2022

Thanks!

avatar brianteeman
brianteeman - comment - 5 Sep 2022

thanks

Add a Comment

Login with GitHub to post a comment