? Language Change ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
25 Aug 2022

Pull request for #32732

The batch process on users lets you remove a user from a group. But it doesn't check to make sure that the user is still in at least one group.

To test

Test 1

  1. Create a new user and put them in the registered usergroup
  2. Using the batch process try to remove them from the registered usergroup

Before

Success message and user not in any group

After

Batch process failed with following error: A user must belong to at least one group.

Test 2

  1. Create a new user and put them in the registered AND author usergroup
  2. Using the batch process try to remove them from the editor usergroup

Before

Success message and user still in the registered and author usergroups

After

Batch process failed with following error: The selected user(s) are not in the selected group.

Test 3

  1. Create a new user and put them in the registered AND author usergroup
  2. Using the batch process try to remove them from the registered usergroup

Before

Success message and user only in the author usergroup

After

Success message and user only in the author usergroup

Comments

This type of code is really not my strong point - it may need optimizing etc

avatar brianteeman brianteeman - open - 25 Aug 2022
avatar brianteeman brianteeman - change - 25 Aug 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 25 Aug 2022
Category Administration com_users Language & Strings
avatar brianteeman brianteeman - change - 25 Aug 2022
Labels Added: Language Change ?
avatar Franzwohlkoenig
Franzwohlkoenig - comment - 26 Aug 2022

I have tested this item successfully on 2081df5


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38596.

avatar Franzwohlkoenig Franzwohlkoenig - test_item - 26 Aug 2022 - Tested successfully
avatar viocassel
viocassel - comment - 27 Aug 2022

I have tested this item successfully on 2081df5


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38596.

avatar viocassel viocassel - test_item - 27 Aug 2022 - Tested successfully
avatar richard67 richard67 - change - 28 Aug 2022
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 28 Aug 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38596.

avatar brianteeman brianteeman - change - 31 Aug 2022
Labels Added: ?
avatar chmst
chmst - comment - 9 Sep 2022

I remember a rule that comments have to start with a capital lettter?

avatar brianteeman
brianteeman - comment - 9 Sep 2022

@chmst yes you're right my bad. also the multiline comment should not use //

suprised the code style check didnt pick this up.

I will update shortly

f940418 9 Sep 2022 avatar brianteeman cs
avatar fancyFranci fancyFranci - change - 15 Sep 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-09-15 21:02:20
Closed_By fancyFranci
avatar fancyFranci fancyFranci - close - 15 Sep 2022
avatar fancyFranci fancyFranci - merge - 15 Sep 2022
avatar fancyFranci
fancyFranci - comment - 15 Sep 2022

Thank you! Great branch name :D

avatar brianteeman
brianteeman - comment - 15 Sep 2022

Wow this gets merged but removing unused CSS doesn't. Makes no sense

Add a Comment

Login with GitHub to post a comment