? ? Pending

User tests: Successful: Unsuccessful:

avatar Fedik
Fedik
24 Aug 2022

Summary of Changes

CaptchaRule ignores the plugin attribute of the field.
This PR fixing it.

Testing Instructions

Enable Captcha (enter invalid site and private keys) and Captcha Invisible (enter correct keys) on your site.
Set Captcha as default in global config.
Edit

<field
name="captcha"
type="captcha"
label="COM_USERS_CAPTCHA_LABEL"
validate="captcha"
/>

Add plugin="recaptcha_invisible"

Then go to Password reset page and try reset.

Actual result BEFORE applying this Pull Request

An error invalid-input-secret or similar

Expected result AFTER applying this Pull Request

No error

Documentation Changes Required

nope

avatar Fedik Fedik - open - 24 Aug 2022
avatar Fedik Fedik - change - 24 Aug 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 Aug 2022
Category Libraries
avatar martin-zw
martin-zw - comment - 6 Oct 2022

I have tested this item successfully on 4a0d346


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38590.

avatar martin-zw martin-zw - test_item - 6 Oct 2022 - Tested successfully
avatar viocassel
viocassel - comment - 18 Oct 2022

I have tested this item successfully on 4a0d346

?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38590.

avatar viocassel viocassel - test_item - 18 Oct 2022 - Tested successfully
avatar richard67 richard67 - change - 23 Oct 2022
Status Pending Ready to Commit
Labels Added: ?
avatar richard67
richard67 - comment - 23 Oct 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38590.

avatar wilsonge wilsonge - close - 25 Oct 2022
avatar wilsonge wilsonge - merge - 25 Oct 2022
avatar wilsonge wilsonge - change - 25 Oct 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-10-25 09:00:34
Closed_By wilsonge
Labels Added: ?
avatar wilsonge
wilsonge - comment - 25 Oct 2022

Thanks!

Add a Comment

Login with GitHub to post a comment