[#38585] - Fix FileLayout to work in non Web context, like Cli, Api
- Fixed in Code Base
- 22 Jan 2023
- Medium
- Build: 4.2-dev
- # 38585
- Diff
- Fedik:fix-layout-cli
User tests: Successful: Unsuccessful:
Fix for stuff like #38222 and #38214 .
Summary of Changes
FileLayout is fail to be render in non Web context, because it does not have a template, obviously.
I changed FileLayout class, so it will ignore the template in non Web context if it not provided within the options.
Testing Instructions
Create file layouts/potato.php with content:
<?php
echo 'Layout works!';Add layout rendering:
$symfonyStyle->success(\Joomla\CMS\Layout\LayoutHelper::render('potato'));Around here
Then from console run php cli/joomla.php cache:clean
Actual result BEFORE applying this Pull Request
an error: getTemplate undefined
Expected result AFTER applying this Pull Request
No error, you should see extra message from potato layout
Documentation Changes Required
Probably. FileLayout support template option, that should be a template name.
| Status | New | ⇒ | Pending |
| Title |
|
||||||
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38585.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38585.
@brianteeman Why the unsuccessful test? What hasn't worked?
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38585.
I have not tested this item.
marking as not tested. Comment to error on this PR #38650 (comment) suggests thatb this PR is not complete
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38585.
@brianteeman that error do not related to FileLayout class which in current PR,
that about PluginHelper::getLayoutPath() that is separated thing, the PR for it is there #39550
I see the remaining issue is covered by another PR #39550 , so this PR here seems to be complete. See comment here: #38650 (comment) .
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38585.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-01-22 13:12:33 |
| Closed_By | ⇒ | fancyFranci |
Thank you for your work, Fedik!
I have tested this item✅ successfully on eb5a5bf
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38585.