[#38576] - tag alias
- Fixed in Code Base
- 7 Sep 2022
- Medium
- Build: 4.2-dev
- # 38576
- Diff
- brianteeman:nested_tags
User tests: Successful: Unsuccessful:
You should be able to create tags with parents and children such as
- Sport
-- adults
-- children - games
-- adults
-- children
Before this PR you could not as you would get a duplicate alias message error even though the tags have different parents and there is no reason that I can see to prevent this I may be very wrong as I dont use tags that often
Pull Request for Issue #21326 .
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | com_tags Administration Language & Strings Libraries |
| Labels |
Added:
Language Change
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38576.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38576.
To be sure that there are no side effects we do not see, please move it to 4.3. Especially with your new tag feature this fix will have the chance to receive deeper tests.
please move it to 4.3.
You already did ;(
| Labels |
Added:
?
PR-4.3-dev
Removed: ? |
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-09-07 19:47:53 |
| Closed_By | ⇒ | obuisard |
Thank you Brian @brianteeman
Please be aware that this change means that routing is going to be broken for the duplicate aliases. The routing currently (and with my rewrite in #39114) simply takes the alias of the tag to identify the tag to load. I would propose to add a switch to either allow single level tags or to use nestable tags and change the routing in that case.
I have tested this item✅ successfully on 46f47fb
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38576.