[#38573] - [5.1]Installation Language
- Fixed in Code Base
- 14 Mar 2024
- Medium
- Build: 4.2-dev
- # 38573
- Diff
- brianteeman:language_sort
User tests: Successful: Unsuccessful:
Pull Request for Issue #36048 .
Summary of Changes
At present the Language Selection in Joomla Installer displays only the nativeName in the list. This makes language names to display in different places not alphabetically by [English] name. This is true especially for language names that do not contain Latin characters. For example, Spanish would appear immediately after English as the native name for Spanish is Español. You can also notice other language such as Tamil (with native name தமிழ்)is listed after the English alphabet names.
Suggestion is to show the language name (ie English Name) along with native name in the list and the list sorted in the language name. This would help to see the languages alphabetically in English. In addition, it would help to find the language easily.
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Installation Libraries |
I raised this a long long time ago so I 10000% agree
And you pr got rejected? If you create a pr I would support it.
| Labels |
Added:
?
|
||
This pull request has been automatically rebased to 5.0-dev.
@HLeithner I made this because you asked
@brianteeman thanks for bringing this up again, I will check and find some testers hopefully soon.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-09-08 11:50:34 |
| Closed_By | ⇒ | brianteeman | |
| Labels |
Added:
Feature
PR-5.0-dev
Removed: ? |
||
| Status | Closed | ⇒ | New |
| Closed_Date | 2023-09-08 11:50:34 | ⇒ | |
| Closed_By | brianteeman | ⇒ |
| Status | New | ⇒ | Pending |
This pull request has been automatically rebased to 5.1-dev.
| Title |
|
||||||
| Labels |
Added:
PR-5.1-dev
|
||
| Labels |
Removed:
PR-5.0-dev
|
||
If this PR is never going to be accepted then please close it. I only made it at the request of the release lead
alpha2 packages are already ready... @LadySolveig can you merge this at some point in time?
@HLeithner @brianteeman sure - it would be a shame if it got lost. I see no tests yet. I will ask for tests again and hopefully merge soon.
The system tests fail at installing. Can be seen here when using the "show all logs" at the top or downloading the complete log. The log then shows:
1) Install Joomla
Install Joomla:
CypressError: Timed out retrying after 4000ms: `cy.select()` failed because it could not find a single `<option>` with value, index, or text matching: `English (United Kingdom)`
It happens in file tests/System/integration/install/Installation.cy.js.
@brianteeman Do you think you can adapt the system tests to your change, or should we try to find someone who can help? Unfortunately I have no knowledge on Cypress.
P.S.: This should not keep people from testing, any later fix for the system tests will not influence the result of human tests.
The issue is not with the test but with the upstream joomla-cypress package node_modules\joomla-cypress\src\joomla.js
The issue is not with the test but with the upstream joomla-cypress package node_modules\joomla-cypress\src\joomla.js
Yes, I meanwhile know, and @LadySolveig will handle it.
I have tested this item ✅ successfully on 186eca2
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38573.
I have tested this item ✅ successfully on d42fc0a
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38573.
I have tested this item ✅ successfully on d42fc0a
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38573.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38573.
I've set RTC despite of the failing system tests as @LadySolveig told me that she will adjust the tests when this PR gets merged.
I just see there is already a PR for adjusting the system tests: joomla-projects/joomla-cypress#11
Thanks @alikon .
Any reason why this RTC pull request is not being merged?
| Labels |
Added:
RTC
|
||
| Category | Installation Libraries | ⇒ | Installation Libraries NPM Change |
| Labels |
Added:
NPM Resource Changed
|
||
| Category | Installation Libraries NPM Change | ⇒ | Installation Libraries |
| Labels |
Removed:
NPM Resource Changed
|
||
Thank you @brianteeman and for the review and for testing to @richard67 @dautrich
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-03-14 17:16:48 |
| Closed_By | ⇒ | LadySolveig |
yay!!
It still depends on localization teams. There are several languages where the
<nativeName>and<name>headers are reversed.Someone needs to contact the localization teams (e.g. Bulgarian, etc.) and fix this. Then we get the result you describe - "alphabetical" and "easy to find".
Just in case, I'll note @tecpromotion. Don't kick me if it's none of your business :).