Joomla! Issue Tracker | Joomla! CMS #38571

Closed
24 Aug 2022
Medium
Build: 4.2-dev
# 38571
Diff
brianteeman:duplicate_module

Pending

User tests: Successful: Unsuccessful:

brianteeman
23 Aug 2022

In certain circumstances (see below) the module title is rendered multiple times.

Pull Request for Issue #37147 and #12888

Testing Instructions

Create a custom module and set the style to "card" and publish on all pages
Create an article and load the module inside the article using {loadmodule}
Check the frontend on any page thaat will display both the article and the module

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

a7c2191 23 Aug 2022

Duplicate module titles

brianteeman - open - 23 Aug 2022

brianteeman - change - 23 Aug 2022

Status

New

⇒

Pending

joomla-cms-bot - change - 23 Aug 2022

Category

⇒

Libraries

brianteeman - comment - 23 Aug 2022

This closes the seventh oldest bug report from 2016 and annoyingly the fix has been here on github for 6 months but no one answered.

RickR2H - comment - 23 Aug 2022

I have tested this item ✅ successfully on a7c2191

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38571.}

RickR2H - test_item - 23 Aug 2022 - Tested successfully

viocassel - comment - 23 Aug 2022

I have tested this item ✅ successfully on a7c2191

?

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38571.}

viocassel - test_item - 23 Aug 2022 - Tested successfully

RickR2H - comment - 23 Aug 2022

RTC

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38571.}

RickR2H - comment - 23 Aug 2022

RTC

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38571.}

RickR2H - comment - 23 Aug 2022

@bembelimen who can check the drone errors? The seems to be not related?

Fedik - comment - 24 Aug 2022

As a quick fix, I would suggest just clone a module, before this code:

joomla-cms/libraries/src/Helper/ModuleHelper.php

Lines 211 to 215 in dd91072

    
           $displayData = array( 
        
               'module'  => $module, 
        
               'params'  => $params, 
        
               'attribs' => $attribs, 
        
           );

$module = clone $module;

$displayData = array(
  'module'  => $module,
  'params'  => $params,
  'attribs' => $attribs,
);

With comment why it is cloned.

~~More advanced fix, is to cache a crome result separated from content and have a flag $module->chromeRendered. Similar to what we done for content:~~

joomla-cms/libraries/src/Helper/ModuleHelper.php

Lines 246 to 250 in dd91072

    
           public static function renderRawModule($module, Registry $params, $attribs = array()) 
        
           { 
        
               if (!empty($module->contentRendered)) { 
        
                   return $module->content; 
        
               }

upd: forget about cache, it have other drawbacks for "chrome"

brianteeman - comment - 24 Aug 2022

Happy for you to submit a pr to my branch. Would be good to fix this very old bug

Fedik - comment - 24 Aug 2022

I made alternative one #38582 please test

brianteeman - comment - 24 Aug 2022

Closed in favour of #38582

brianteeman - change - 24 Aug 2022

Status	Pending	⇒	Closed
Closed_Date	0000-00-00 00:00:00	⇒	2022-08-24 11:52:48
Closed_By		⇒	brianteeman
Labels	Added: ?

brianteeman - close - 24 Aug 2022

Add a Comment

Older
Newer

Joomla! Issue Tracker - CMS

[#38571] - Duplicate module titles

Testing Instructions

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Add a Comment

	$displayData = array(
	'module' => $module,
	'params' => $params,
	'attribs' => $attribs,
	);

	public static function renderRawModule($module, Registry $params, $attribs = array())
	{
	if (!empty($module->contentRendered)) {
	return $module->content;
	}