User tests: Successful: Unsuccessful:
In german Tupel would be correct, but in english the variable has to be named "tuple".
Status | New | ⇒ | Pending |
Category | ⇒ | Administration com_fields |
Hmm do you have the link to the PR that you did for that or remember the reason to redject it? Its a variable used only in the save method so I dont see an issue here on a quick look. Technical it could be argued that such a change in a layout or variable used within an layout could be a B/C issue but looks like the github search does only find "tupel" within other two unrelated issues and this PR here https://github.com/joomla/joomla-cms/search?q=tupel&type=issues
The first PR was closed by the person who opend the PR and not redjected. The second PR is kind of a b/c issue as benjamin mentiond there. This PR here should be fine from this perspective.
I would have remade the first one but didnt because of the answer to the second one
The first one should not have a b/c issue but I'm not 100% sure with that sentence by @HLeithner there. But this here is "just" the variable name thats not used within layouts and not used in signatures so this should be fine. The seccond one is not the variable name but the content of an variable. As J5 is open both PRs could be made against it to get it fixed finally.
No idea why there is such a long discussion the variable is only in local scope and can be changed to whatever you want. This can be merged into 4.2.2 from my point of you.
I have tested this item
I have tested this item
Status | Pending | ⇒ | Ready to Commit |
RTC
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-09-06 08:08:06 |
Closed_By | ⇒ | wilsonge | |
Labels |
Added:
?
?
|
Thanks!
the suggested change to english is correct. I dont know if there are any consequences of renaming this variable. when I tried to correct a variable name before it was rejected.