? ? Pending

User tests: Successful: Unsuccessful:

avatar sba
sba
23 Aug 2022

In german Tupel would be correct, but in english the variable has to be named "tuple".

avatar sba sba - open - 23 Aug 2022
avatar sba sba - change - 23 Aug 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 23 Aug 2022
Category Administration com_fields
avatar brianteeman
brianteeman - comment - 23 Aug 2022

the suggested change to english is correct. I dont know if there are any consequences of renaming this variable. when I tried to correct a variable name before it was rejected.

avatar zero-24
zero-24 - comment - 23 Aug 2022

Hmm do you have the link to the PR that you did for that or remember the reason to redject it? Its a variable used only in the save method so I dont see an issue here on a quick look. Technical it could be argued that such a change in a layout or variable used within an layout could be a B/C issue but looks like the github search does only find "tupel" within other two unrelated issues and this PR here https://github.com/joomla/joomla-cms/search?q=tupel&type=issues

avatar brianteeman
brianteeman - comment - 23 Aug 2022
avatar zero-24
zero-24 - comment - 23 Aug 2022

The first PR was closed by the person who opend the PR and not redjected. The second PR is kind of a b/c issue as benjamin mentiond there. This PR here should be fine from this perspective.

avatar brianteeman
brianteeman - comment - 23 Aug 2022

I would have remade the first one but didnt because of the answer to the second one

avatar zero-24
zero-24 - comment - 23 Aug 2022

The first one should not have a b/c issue but I'm not 100% sure with that sentence by @HLeithner there. But this here is "just" the variable name thats not used within layouts and not used in signatures so this should be fine. The seccond one is not the variable name but the content of an variable. As J5 is open both PRs could be made against it to get it fixed finally.

avatar HLeithner
HLeithner - comment - 23 Aug 2022

No idea why there is such a long discussion the variable is only in local scope and can be changed to whatever you want. This can be merged into 4.2.2 from my point of you.

avatar ChristineWk
ChristineWk - comment - 23 Aug 2022

I have tested this item successfully on 2929f1e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38569.

avatar ChristineWk ChristineWk - test_item - 23 Aug 2022 - Tested successfully
avatar viocassel
viocassel - comment - 24 Aug 2022

I have tested this item successfully on 2929f1e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38569.

avatar viocassel viocassel - test_item - 24 Aug 2022 - Tested successfully
avatar alikon alikon - change - 24 Aug 2022
Status Pending Ready to Commit
avatar alikon
alikon - comment - 24 Aug 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38569.

avatar wilsonge wilsonge - change - 6 Sep 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-09-06 08:08:06
Closed_By wilsonge
Labels Added: ? ?
avatar wilsonge wilsonge - close - 6 Sep 2022
avatar wilsonge wilsonge - merge - 6 Sep 2022
avatar wilsonge
wilsonge - comment - 6 Sep 2022

Thanks!

Add a Comment

Login with GitHub to post a comment