[#38554] - Merge branch 4.2 into 4.3
- Fixed in Code Base
- 23 Aug 2022
- Medium
- Build: 4.3-dev
- # 38554
- Diff
- joomla:4.2-dev
- Success continuous-integration/appveyor/branch AppVeyor build succeeded Details
- Success continuous-integration/drone/push Build is passing Details
- Success continuous-integration/drone Build is passing Details
- Success Download Prebuilt packages are available for download. Details
User tests: Successful: Unsuccessful:
![avatar github-actions[bot]](/images/avatars/github-actions[bot].png)
| Status | New | ⇒ | Pending |
| Category | ⇒ | Administration com_admin SQL Postgresql com_joomlaupdate com_users Language & Strings |
Why is this PR deleting the update SQL scripts „4.2.0-2022-07-07.sql“?
Hi Richard, it was not meant to. I am just doing an up merge and I have not taken any action on this yet (setting up my local environment to deal with the conflicts).
The SQL scripts do not exist under 4.2-dev
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-08-23 01:05:19 |
| Closed_By | ⇒ | obuisard | |
| Labels |
Added:
?
Language Change
PR-4.3-dev
|
||
@obuisard The 2 update SQL scripts have been deleted in the 4.2-dev branch when reverting PR #38244 . But that was maybe not right. I do not have the time today to check that deeper.
@richard67 I will take a look today and see if I can lift the doubt on this deletion. Thank you Richard!
Apparently, as @richard67 posted in the CMS Maintenance team, the deleted files need to be added to script.php so they are removed on update.
Apparently, as @richard67 posted in the CMS Maintenance team, the deleted files need to be added to script.php so they are removed on update.
Yes but that should have been done in the 4.2-dev branch. And it would have been better not to delete the files but just to comment out the content, and possibly it would even have been necessary to add new update SQL scripts which delete the records added by the deleted script on a 4.2.0. RC1.
@roland-d I would have expected to be contacted when such a thing happens, reverting a PR which has update SQL scripts.
And when we remove them again on update, the database checker will complain about not matching schema version. As this will only happen when updating a 4.2.0 RC 1, I tend to ignore that for now, i.e. do nothing and leave things as they are.
Ok, I am taking note so that I remember that next time I run into such issue
Please add more information to your issue. Without test instructions and/or any description we will close this issue within 4 weeks. Thanks.
This is an automated message from the J!Tracker Application.