? ? ? Success

User tests: Successful: Unsuccessful:

avatar zjw
zjw
2 Jul 2014

(Joomla Feature tracker: http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=33918&start=0)

Currently, only full URLs are searched for amoung the "Expired URLs" entered in the Redirect component. This PR permits the matching of relative path URLs entered in the component as well.

Advantages:

Joomla! sites accessible with http and https don't need to enter separate redirects for each scheme.

Joomla! sites accessible via multiple domain names don't need to enter separate redirects for each domain.

If an entire Joomla! site is relocated, the redirects for the site don't need to be rewritten based on the new location.

Changes:

When editing a redirect in the component, the tool tip for the source URL has been updated.

When viewing the list of redirects in the component, the entire "Expired URL" is displayed just as it was entered. Previously, the Joomla! root of the path was hidden. Now, if a full URL was entered, the full URL is displayed. If only a relative path was entered, only the relative path is displayed.

In the plugin, a search for a redirect match is first made using the full URL. If no match is found, the the full URL is modified by removing the Joomla! root (if it exists), and a second search is performed for a matching relative path.

When no match is found, the behavior has slightly changed. The old behavior was to always add the full URL to the list of redirects. The new behavior is to add a relative path URL to the list of redirects if the full URL begins with the Joomla! root.

To test:

Install the patched version of Joomla! on an apache server with some sample data.

For example, assume the base installation is located here:

http://example.com/index.php

In the site configuration, enable:

Search Engine Friendly URLs
Use URL rewriting
Adds Suffix to URL

Enable the System/Redirect plugin

copy htaccess.txt to .htaccess

In the Redirect component, create a redirect with a relative path as the source/expired URL:

foo/bar/missing.html -> http://example.com/index.php

Visiting the expired URL (http://example.com/foo/bar/missing.html) should properly redirect.

Attempting to access an non-existant URL (e.g., http://example.com/foo/bar/also_missing.html) should automatically create an expired URL in the redirect component which is stored as a relative path (foo/bar/also_missing.html).

avatar zjw zjw - open - 2 Jul 2014
avatar zjw zjw - change - 2 Jul 2014
Title
Permit relative "Expired URLs" in the Redirect component/plugin
[#33918] Permit relative "Expired URLs" in the Redirect component/plugin
avatar brianteeman brianteeman - change - 8 Aug 2014
Labels Added: ?
avatar brianteeman brianteeman - change - 21 Aug 2014
Status New Pending
avatar nicksavov nicksavov - change - 21 Aug 2014
Labels Removed: ?
avatar dbhurley
dbhurley - comment - 26 Sep 2014

Thanks for coding this feature! We're near the close for new features to be included in 3.4 however this should be accepted for 3.5 release coming soon.

We'll need to see tests before we can move to Ready-To-Commit (RTC)

avatar zero-24
zero-24 - comment - 13 Mar 2015

@zjw can you update your branche to staging to fix merge conflicts? Thanks!

avatar roland-d
roland-d - comment - 3 Nov 2015

Hello @zjw

Thank you for your contribution.

The last comment here was on 13th March. So the question is, Is this issue/pull request still valid?
if so please provide clear test instructions to be able to test / reproduce this issue. Also fix the merge conflicts please.
If no reply is received within 4 weeks we will close this issue.

Thanks for understanding!

avatar roland-d roland-d - change - 8 Nov 2015
Status Pending Information Required
avatar brianteeman brianteeman - change - 17 Dec 2015
Status Information Required Closed
Closed_Date 0000-00-00 00:00:00 2015-12-17 11:10:18
Closed_By brianteeman
avatar brianteeman brianteeman - close - 17 Dec 2015
avatar brianteeman brianteeman - close - 17 Dec 2015
avatar brianteeman
brianteeman - comment - 17 Dec 2015

Closed due to lack of response for further information - it can always be reopened if that is provided


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/3855.

avatar joomla-cms-bot joomla-cms-bot - change - 17 Dec 2015
Labels Added: ?

Add a Comment

Login with GitHub to post a comment