User tests: Successful: Unsuccessful:
Pull Request for Issue #38543 .
Modified the User table to add empty string values to the otpKey
and otep
columns if they are empty.
NORMALLY THIS SHOULD NOT BE NECESSARY. The table definition gives a default value of an empty string to both columns and the reported issue cannot be reproduced.
However, if your site came from a series of upgrades from older versions and/or transferred between servers by hand it might end up having these columns as NOT NULL
but without a default value.
From the CLI folder run
php joomla.php user:add --username=foobar --name="Foo Bar" --email=foobar@example.com --password="P@s5w0rD" --usergroup=Registered
It works on all sites except the issue reporter's site.
It works on all sites.
None.
Status | New | ⇒ | Pending |
Category | ⇒ | Libraries |
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-09-08 10:14:18 |
Closed_By | ⇒ | nikosdion | |
Labels |
Added:
?
|
OK, I guess people don't care if a site is kinda broken from successive updates. Can't really blame them, this only ever happened to one site I am aware of. So, I am closing this PR.
https://forum.joomla.org/viewtopic.php?f=808&t=998623 appears to be the same problem
Status | Closed | ⇒ | New |
Closed_Date | 2022-09-08 10:14:18 | ⇒ | |
Closed_By | nikosdion | ⇒ |
Status | New | ⇒ | Pending |
Reopening as this is a recurring issue, per #38549 (comment)
Kind reminder @fancyFranci @roland-d that this needs to be fixed in 4.2, ideally four months ago.
BTW, this fixes a simple mistake I made in an earlier PR that none of you caught (because y'all were too busy bikeshedding instead of actually testing during the entire month you were bombarding me with hundreds of mostly nonsense comments). Also note that I came here with a fix for it as soon as 4.2.1 was out which is when people actually started upgrading to 4.2. I don't understand why this trivial fix of an issue with a real world impact is still languishing in the PR purgatory.
I have tested this item
Status | Pending | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-12-23 09:09:49 |
Closed_By | ⇒ | zero-24 |
Merging thanks @nikosdion
Thank you! This will help folks work with their legacy template overrides without undue frustration
I have tested this item✅ successfully on 12f665c
code review
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38549.