? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
21 Aug 2022

Summary of Changes

add three more errors to ignore as a temp measure until they have been whitelisted and/or bugfixed upstream

To test apply the pr and try to upload all the svg in the attached zip

It still correctly refuses to upload the bad files and there are less false positives

svg.zip

avatar brianteeman brianteeman - open - 21 Aug 2022
avatar brianteeman brianteeman - change - 21 Aug 2022
Status New Pending
avatar brianteeman brianteeman - change - 21 Aug 2022
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 21 Aug 2022
Category Libraries
e8cce7c 21 Aug 2022 avatar brianteeman cd
avatar Abernyte-Git
Abernyte-Git - comment - 22 Aug 2022

As well as the three bad files getting "unable to upload" I also get "cleaned_example6, example4 and example5 getting "unable to upload"
Do you wish this marked as a fail or was this expected?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38545.

avatar brianteeman
brianteeman - comment - 22 Aug 2022

Do you wish this marked as a fail or was this expected?

as expected. fewer false positives

avatar Abernyte-Git
Abernyte-Git - comment - 22 Aug 2022

I have tested this item successfully on e8cce7c

Okay


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38545.

avatar Abernyte-Git Abernyte-Git - test_item - 22 Aug 2022 - Tested successfully
avatar viocassel
viocassel - comment - 23 Aug 2022

I have tested this item successfully on e8cce7c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38545.

avatar viocassel viocassel - test_item - 23 Aug 2022 - Tested successfully
avatar RickR2H RickR2H - change - 23 Aug 2022
The description was changed
Status Pending Ready to Commit
avatar RickR2H
RickR2H - comment - 23 Aug 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38545.

avatar joomla-cms-bot joomla-cms-bot - edited - 23 Aug 2022
avatar fancyFranci fancyFranci - change - 14 Sep 2022
Labels Added: ?
avatar fancyFranci fancyFranci - change - 14 Sep 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-09-14 07:31:05
Closed_By fancyFranci
avatar fancyFranci fancyFranci - close - 14 Sep 2022
avatar fancyFranci fancyFranci - merge - 14 Sep 2022
avatar fancyFranci
fancyFranci - comment - 14 Sep 2022

Thank you Brian :)

avatar brianteeman
brianteeman - comment - 14 Sep 2022

thanks

Add a Comment

Login with GitHub to post a comment