Joomla! Issue Tracker | Joomla! CMS #38535 - [4.2] Do not set a width of 0 in media thumbnails

? NPM Resource Changed ?

Fixed in Code Base
2 Sep 2022
Medium
Build: 4.2-dev
# 38535
Diff
Digital-Peak:media/thum/width

Pending

User tests: Successful: Unsuccessful:

laoneo
19 Aug 2022

Summary of Changes

Since #36930 the thumbnail image of a media item is an image HTML element. When the width and height are 0, then the image is rendered with 0 width/height and invisible. Instead of the attributes should be ignored. This pr adds no attribute when width and height are not available and sets loading not to lazy.

Testing Instructions

Remove the lines 342 and 343 in plugins/filesystem/local/src/Adapter/LocalAdapter.php
Open the media manager in the back end

Actual result BEFORE applying this Pull Request

No preview image is visible, because it has width and height of 0.

Expected result AFTER applying this Pull Request

A preview image is shown with no width/height/loading attribute.

01d9d49 19 Aug 2022

Do not set a width of 0 in media thumbnails

laoneo - open - 19 Aug 2022

laoneo - change - 19 Aug 2022

Status

New

⇒

Pending

joomla-cms-bot - change - 19 Aug 2022

Category

⇒

Administration com_media NPM Change

laoneo - change - 19 Aug 2022

The description was changed

laoneo - edited - 19 Aug 2022

4c87bcb 20 Aug 2022

Merge branch '4.2-dev' into media/thum/width

laoneo - change - 20 Aug 2022

Labels

Added: NPM Resource Changed ?

brianteeman - comment - 20 Aug 2022

After rebuilding the media manager I can confirm this works

BUT - in what scenario would the image ever have a height/width of 0?

laoneo - comment - 21 Aug 2022

When you fetch data from an external service like FTP, then there is no image information. Since 4.1 a width/height attribute is required as int value, the adapter has to return at least 0. You can try it with the free version of DPMedia and the FTP adapter.

brianteeman - comment - 21 Aug 2022

I have tested this item ✅ successfully on 4c87bcb

Thanks for explaining the use case

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38535.}

brianteeman - test_item - 21 Aug 2022 - Tested successfully