? ? Pending

User tests: Successful: Unsuccessful:

avatar nikosdion
nikosdion
19 Aug 2022

Pull Request for Issue #38476 .

Summary of Changes

The Joomla\CMS\Application\MultiFactorAuthenticationHandler::isMultiFactorAuthenticationPage method is now public and has an optional argument to only consider captive pages.

The plg_system_stats plugin uses this method to check whether it is running a captive MFA page and refuse to continue.

A previously hard-coded exception for the stats plugin has been removed from the MultiFactorAuthenticationHandler Trait.

Testing Instructions

  • Install Joomla 4.2.0
  • DO NOT make a choice about the stats collection just yet
  • Set up MFA for your user account
  • Log out
  • Log back in

Actual result BEFORE applying this Pull Request

You see the stats collection interface in the captive MFA page. Trying to use its buttons leads to a broken display experience as per the issue #38476.

Expected result AFTER applying this Pull Request

You do NOT see the stats collection interface in the captive MFA page or any of the captive pages you are allowed access to (basically, selecting an MFA method). It does appear after completing the MFA validation.

Documentation Changes Required

Plugins which render user interfaces in the backend of the site must check whether they are running under the Multi-factor Authentication feature's captive pages using the following code:

method_exists($this->app, 'isMultiFactorAuthenticationPage')
            && $this->app->isMultiFactorAuthenticationPage(true);

If this returns true the plugin MUST NOT render its user interface.

avatar nikosdion nikosdion - open - 19 Aug 2022
avatar nikosdion nikosdion - change - 19 Aug 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 19 Aug 2022
Category Libraries Front End Plugins
avatar bayareajenn
bayareajenn - comment - 19 Aug 2022

I have tested this item successfully on 2da7737


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38533.

avatar bayareajenn bayareajenn - test_item - 19 Aug 2022 - Tested successfully
avatar softforge
softforge - comment - 20 Aug 2022

I have tested this item successfully on 2da7737

I tested using yubikey as my MFA choice and can confirm the stats were NOT showing on the yubikey entry page with this patch applied and once logged in reshowed until I made a choice


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38533.

avatar softforge softforge - test_item - 20 Aug 2022 - Tested successfully
avatar richard67
richard67 - comment - 20 Aug 2022

I have tested this item successfully on 2da7737

3rd test is not a bad thing.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38533.

avatar richard67 richard67 - change - 20 Aug 2022
Status Pending Ready to Commit
Labels Added: Release Blocker ?
avatar richard67
richard67 - comment - 20 Aug 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38533.

avatar richard67 richard67 - test_item - 20 Aug 2022 - Tested successfully
avatar fancyFranci fancyFranci - change - 20 Aug 2022
Labels Added: ?
avatar roland-d roland-d - change - 20 Aug 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-08-20 18:06:59
Closed_By roland-d
Labels Removed: Release Blocker
avatar roland-d roland-d - close - 20 Aug 2022
avatar roland-d roland-d - merge - 20 Aug 2022
avatar roland-d
roland-d - comment - 20 Aug 2022

Thank you

Add a Comment

Login with GitHub to post a comment