User tests: Successful: Unsuccessful:
Pull Request for Issue #38476 .
The Joomla\CMS\Application\MultiFactorAuthenticationHandler::isMultiFactorAuthenticationPage
method is now public and has an optional argument to only consider captive pages.
The plg_system_stats
plugin uses this method to check whether it is running a captive MFA page and refuse to continue.
A previously hard-coded exception for the stats plugin has been removed from the MultiFactorAuthenticationHandler
Trait.
You see the stats collection interface in the captive MFA page. Trying to use its buttons leads to a broken display experience as per the issue #38476.
You do NOT see the stats collection interface in the captive MFA page or any of the captive pages you are allowed access to (basically, selecting an MFA method). It does appear after completing the MFA validation.
Plugins which render user interfaces in the backend of the site must check whether they are running under the Multi-factor Authentication feature's captive pages using the following code:
method_exists($this->app, 'isMultiFactorAuthenticationPage')
&& $this->app->isMultiFactorAuthenticationPage(true);
If this returns true the plugin MUST NOT render its user interface.
Status | New | ⇒ | Pending |
Category | ⇒ | Libraries Front End Plugins |
I have tested this item
I tested using yubikey as my MFA choice and can confirm the stats were NOT showing on the yubikey entry page with this patch applied and once logged in reshowed until I made a choice
I have tested this item
3rd test is not a bad thing.
Status | Pending | ⇒ | Ready to Commit |
Labels |
Added:
Release Blocker
?
|
RTC
Labels |
Added:
?
|
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-08-20 18:06:59 |
Closed_By | ⇒ | roland-d | |
Labels |
Removed:
Release Blocker
|
Thank you
I have tested this item✅ successfully on 2da7737
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38533.