[#38516] - [4.2] Empty folder
- Fixed in Code Base
- 18 Aug 2022
- Medium
- Build: 4.2-dev
- # 38516
- Diff
- brianteeman:build
User tests: Successful: 2 ReLater, richard67 Unsuccessful: 0
Removes the empty folder libraries/vendor/symfony/string/Resources/bin from the distributed release.
Pull Request for Issue #38515
Test by code review and by checking that the folder doesnt exist in the pre-built package for this pr
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Repository |
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38516.
@brianteeman can you please add the deletion of that folder into the script.php too so this will be deleted for existing installed sites.
@brianteeman can you please add the deletion of that folder into the script.php too so this will be deleted for existing installed sites.
@zero-24 As far as I remember we once have decided that we don't leave the deleted files and folders in script.php up to the PR authors in J4 but we (maintainers, mostly me) do it for them.
Thats why I didnt do it
But to make life easier I just did it
| Category | Repository | ⇒ | Administration com_admin Repository |
@richard67 ps you probably need to add hotkeys.js as a folder to remove as it was present in beta releases but is now renamed as hotkeysjs
@brianteeman can you please add the deletion of that folder into the script.php too so this will be deleted for existing installed sites.
@zero-24 As far as I remember we once have decided that we don't leave the deleted files and folders in script.php up to the PR authors in J4 but we (maintainers, mostly me) do it for them.
Ok didnt know about this change can you do a PR against the checklist so its not forgotten when other people are doing the releases?
@richard67 ps you probably need to add hotkeys.js as a folder to remove as it was present in beta releases but is now renamed as hotkeysjs
@brianteeman Thanks, will keep that in mind.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38516.
I have tested this item
Checked the packages built by drone for this PR and checked that updating works with the update package and the changed script.php.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38516.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38516.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-08-18 18:17:31 |
| Closed_By | ⇒ | fancyFranci | |
| Labels |
Added:
?
|
||
Thank you! One more step for a better release
I have tested this item✅ successfully on 5d962b2
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38516.