Think we need some more info here because the is_string call immediately above this line should fail before you've reached the trim

I agree I would say we should not pass an empty string to that method in the first place.

Think we need some more info here because the is_string call immediately above this line should fail before you've reached the trim

@wilsonge @zero-24

If $path = NULL it will pass if (!\is_string($path) && !empty($path)) {

I test in my local with var_dump
var_dump($path, is_string($path), empty($path));

Result Below

Yes thats the reason I would not like to add that if else catch in every method that is handeling strings and hide the issues of passing null or empty strings to methods which should not be called with empty strings in the first place.

Yes thats the reason I would not like to add that if else catch in every method that is handeling strings and hide the issues of passing null or empty strings to methods which should not be called with empty strings in the first place.

Yeah! I fixed it in my component. Anyway, I think other extensions will face that when customer update PHP to 8.1

yes when the extension is ready for 8.1 that message does not come up right? When it is not ready for 8.1 yet the issue should be reported to the developer so it can be fixed right? Right now its not an fatal error by php yet anyway so "hiding" error messages "hides" the issue in the same way but allows the developer to find and fix it too.

Maybe the
if (!\is_string($path) && !empty($path)) {
should be changed to something like
if ($path === null || (!\is_string($path) && !empty($path))) {
?

As long as a library accepts null values is should work properly and not throw different errors on different PHP versions. So making a change in the library is fine.

Maybe the if (!\is_string($path) && !empty($path)) { should be changed to something like if ($path === null || (!\is_string($path) && !empty($path))) { ?

You are right! I updated code with if ($path === null || (!\is_string($path) && !empty($path))) {

Best Regards,

This is now a BC break as an exception is thrown when the path is null, which wasn't before.

This is now a BC break as an exception is thrown when the path is null, which wasn't before.

May you me give a suggestion? Raise an exception to force developer fix in their code or set $path = '' to ignore it. I'm wondering about that.

Thanks & Best Regards,

I would go with something like:

if ($path === null) {
	@trigger_error(
		sprintf(
			'Path can not be null, in 5.0 it will throw an exception',
			__METHOD__
		),
		E_USER_DEPRECATED
	);
	$path = '';
}

@laoneo Thank you for the suggestion! Because no one came up with a better idea. I have updated the code as per your suggestion.

Please help me check it again!

Looks correct now. Thanks!

When you update the test instructions and expected/actual result the way, that the testers know what to do, then it is very likely that you change gets merged. You can put something like in testing instructions with some files in core:

• Add this code to the file XY at line ZZ
• Open the page XY

Similar to what I did in #38535.

@laoneo Thank you! I updated test instructions.

Best Regards,
Sonny

I have tested this item ✅ successfully on 3ae8337

I have tested this item ✅ successfully on 7e61399

@alikon , can you please retest since a change was made?

no need to retest @jwaisner only branch merge

I have tested this item ✅ successfully on daaf175

RTC

This has to go into 4.3 as it adds a deprecation. So waiting for the upmerge to make a rebase.

PR for manual can be found here joomla/Manual#33.

Thank you all for working on this issue!