[#38504] - Make sure the itemID is of type int
- Fixed in Code Base
- 17 Aug 2022
- Medium
- Build: 4.2-dev
- # 38504
- Diff
- roland-d:feature/fix-getmenulanguage
User tests: Successful: 0 Unsuccessful: 0
Pull Request for Issue #38489.
Summary of Changes
When you have a login menu item and use that on a multi-lingual site, logging in will end in failure Argument must be of the type int
Testing Instructions
- Use a mutli-language site
- Create a menu item of the type Login
- Set the redirect to another menu item
- Try to login on the frontend
- You see the fatal error
- Apply patch
- Try to login again
- You are now redirected to the page set in the menu item
Actual result BEFORE applying this Pull Request
Fatal error on login on multi-language site
Expected result AFTER applying this Pull Request
User is logged in
Documentation Changes Required
None
Votes
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_users |
@brianteeman What did I do wrong?
tested succesfully
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38504.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38504.
tested succesfully
@obuisard Make sure you have correctly setup your multi-lingual site. Check that all plugins related to multi-lingual are enabled. If the multi-lingual check fails, the error will not be seen.
Yes, all seems good, all plugins are enabled, and the site works as expected.
tested succesfully
@cappuccinonet Please mark your test result in the issue tracker so it is properly counted. For doing this, go to https://issues.joomla.org/tracker/joomla-cms/38504 , click the blue "Test this" button at the top left corner, select your test e and submit. Thanks in advance.
tested successfully
Hello @cappuccinonet, please report your test in the issue tracker to report it. Thank you! Your help is appreciated.
https://issues.joomla.org/tracker/joomla-cms/38504
Sorry, I was not fast enough lol
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38504.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38504.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38504.
@roland-d I set did set the tag to PR-4.3-dev. Please change id this is not correct!
@RickR2H As you should be able to see, the base branch of this PR is 4,.2-dev, and so it needs the PR-4.2-dev label. It should also be easy to see on GitHub which labels were removed by the issue tracker when setting RTC, and so you should add back only these.
| Labels |
Added:
?
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-08-17 17:32:18 |
| Closed_By | ⇒ | bembelimen |
Thx
Third attempt at fixing the same problem :(