User tests: Successful: Unsuccessful:
Pull Request for Issue #38473 .
deal with INFinite
introduced by #37457
use redis Cache Handler
Redis::setex(): Argument #2 ($expire) must be of type int, float given
works as before
Status | New | ⇒ | Pending |
Category | ⇒ | Libraries |
@roland-d I had the same issue and it's solved with this fix.
I have tested this item
Issue is gone after replacing RedisStorage.php with the fixed version.
@roland-d check linked PR
@alikon Probably we better change INF
to a 1 year 31557600
(or a couple years):
joomla-cms/libraries/src/Version.php
Lines 309 to 310 in 937df36
It will be more safe than hacking every potential issue with Cache drivers.
You will update or I do PR?
Set it to 10 years 315576000
in redis term if something "never expire" the there is no need to setex() just store it set()
in redis term if something "never expire" the there is no need to setex() just store it set()
Yeah, but we also better cover our backs.
Because other drivers may have similar issue, they may expect integer for lifetime, while PHP INF
is float
.
Labels |
Added:
?
|
I have tested this item
Cannot do a real test, but on review looks good. Changing INF
Float to Integer for a lifetime value
The code comment before the changed line does not fit any more. Could you please edit it and explain the 10 years in the comment? :)
Labels |
Added:
Release Blocker
|
RTC
Status | Pending | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-08-18 18:48:49 |
Closed_By | ⇒ | roland-d | |
Labels |
Removed:
Release Blocker
|
@Stuartemk could you give this a test please and see if it resolves your issue?