I have tested this item ✅ successfully on 1e62228

I have tested this item ✅ successfully on 1e62228

RTC

@brianteeman Does this PR solve the 2 issues #38455 and #30908 so they can be closed?

Just from code review: we have to be careful to not allow: "...hello...bla.min"

@bembelimen I did wonder about that but I assumed (maybe incorrectly) that as we didnt allow the slash it would not be a problem?

please remove the RTC on this.

@bembelimen was correct and we need to prevent a .. in the filename. I was only thinking of security but actually it blows away the php if its allowed. - will update this PR later

Back to pending due to reason stated in previous comment.

Please retest and confirm that you can now create, rename files with a dot in them AND that you cannot when there are two or more dots

Whats with a "invisible space" IIRC thats not catched by strpos. Or some kind of none breaking change as well as some unicode char thats confusing the filename/filesystem? didnt we have a filter class where we could throw this file name against too?

@zero-24 The file is already going through a filter before this iirc. If not then its beyond the scope of this PR as it would be possible before this PR as well. please test those yourself.

I have tested this item ✅ successfully on fa2068e

Tested again. With one dot - the file was created, with two or more - an error.

I have tested this item ✅ successfully on fa2068e

RTC

"." should not be allowed at the beginning of the name (as then the file is hidden) and also not at the end of the name (to avoid again the ".." with the extension.

should not be allowed at the beginning of the name
Its not - either before or after this pr. In both cases the leading dot is stripped

also not at the end of the name
yeah thats a bug in the regex will need to fix thaat after the holiday

please remove rtc for now

Back to pending.

Sorry I must have got distracted. I had the correct regex already written but for some reason I didnt include it.

You can test the regex here https://rextester.com/RULEP70144

I have tested this item ✅ successfully on e291abb

I have tested this item ✅ successfully on e291abb

RTC

RTC

I would really like to merge it, but regex with this size are tricky and need more tests. I'm wondering where the underscore in the first regex went? But 4.3 has the time to test intensively, so I'm moving the PR.

There will be zero extra tests. Look at who has already tested it.

As @fancyFranci noticed, it does not allow underscore in the regexp anymore. A file name like joomla_78.min.css will fail.
Why are the regular expressions different in create/rename? Shouldn't they be identical?

Sorry, don't want to be the party pooper again. So I tested it:

Before:

Edit/Create file:

• _bla.scss => works
• bla.min.css => does not work
• text-file.php => works
• .hui.txt => converted to "hui.txt" andsaved (should probably give an error)

After:

Create file:

• _bla.scss => does not work
• bla.min.css => works
• text-file.php => does not work
• .hui.txt => converted to "hui.txt"

Edit file:

• _bla.scss => works
• bla.min.css => does not work
• text-file.php => works
• .hui.txt => converted to "hui.txt" and saved

I also think I was wrong regaring the "." at the beginning, there is no test needed as the getCmd filter already removed the ".". So I think (?!.*\\..*\\..*) is not needed at the beginning?

Back to pending

Please make up your minds.

Closed

My intention was not to block it :( just giving it a proper testing as I think it's a nice feature.

The difference in create and edit comes from the fact that they both use a different regular expression, therefore you get different results. Nothing major :-)

@brianteeman this is a good PR, it addresses issues encountered by users.
Would you mind re-opening it? Thank you.

@obuisard There is PR #38987 .

what he said

Thank you and super :-) @brianteeman @richard67