No Code Attached Yet
avatar coolcat-creations
coolcat-creations
13 Aug 2022

Is your feature request related to a problem? Please describe.

In School class I showed how to customize a template. If you want to upload or rename a min.js or a min.css file to the template manager it's not allowed.

Describe the solution you'd like

Allow .min. files in the template manager

avatar coolcat-creations coolcat-creations - open - 13 Aug 2022
avatar joomla-cms-bot joomla-cms-bot - change - 13 Aug 2022
Labels Added: No Code Attached Yet
avatar joomla-cms-bot joomla-cms-bot - labeled - 13 Aug 2022
avatar brianteeman
brianteeman - comment - 13 Aug 2022

For reference the original reason to prevent the upload of ..* filenames was to address a security issue. I have no idea if that is still relevant but it explains why it is currently prevented

avatar Quy
Quy - comment - 13 Aug 2022

Duplicate #30908?

avatar brianteeman
brianteeman - comment - 13 Aug 2022

So I remembered what the security issue was and found the code that deals with it.

The good news is that code does not prevent .min. and I have verified that I can upload both a min.js and a min.css file

chrome_kQ05L6Nzp3.mp4
avatar brianteeman
brianteeman - comment - 13 Aug 2022

Currently it is not possible to rename a file example.csss to example.min.css but is that necessary?
It is a very quick fix if it is necessary and it would be acceptable for it to be

image

avatar coolcat-creations
coolcat-creations - comment - 14 Aug 2022

I can't rename a template.min.css to style.min.css. I mean that's a simple wish to something and could be frustrating if it's not possible. It would be really nice if it's possible.

avatar brianteeman
brianteeman - comment - 14 Aug 2022

if the option shown in the screenshot is acceptable it is a 2 second pr

avatar coolcat-creations
coolcat-creations - comment - 14 Aug 2022

Means I can upload a min.js but still not create? It would be at least a part of the solution. Creation would be appreciated too when they do not use an IDE in the first moment :-)

avatar brianteeman
brianteeman - comment - 14 Aug 2022

creating is a bit harder as the regex is more comples but i will take a look

avatar brianteeman
brianteeman - comment - 14 Aug 2022

please test #38458

avatar richard67 richard67 - change - 18 Oct 2022
Status New Closed
Closed_Date 0000-00-00 00:00:00 2022-10-18 08:51:50
Closed_By richard67
avatar richard67 richard67 - close - 18 Oct 2022
avatar richard67
richard67 - comment - 18 Oct 2022

Closing as having a pull request. Please test #38987 . Thanks in advance.

Add a Comment

Login with GitHub to post a comment