Feeling Lucky
?
PR-4.3-dev
[#38441] - [4.3] Convert recaptcha plugin to services and add captcha plugin interface
- Closed
- 12 Aug 2022
- Medium
- Build: 4.3-dev
- # 38441
- Diff
- Digital-Peak:j4/plugins/recaptcha
User tests: Successful: Unsuccessful:
Summary of Changes
The pr introduces a new interface for captcha based plugins so operations on them is more clear. Additionally it deprecates the Captcha class as it basically duplicates the code of the bootPlugin operation and does some method checks for plugins which do not implement the interface.
Testing Instructions
- Setup the recaptcha and invisible captcha plugin in the plugin manager with the proper keys
- Select recaptcha in the contact options in the form tab
- Create a single contact menu item
- Open that contact menu item and send a mail as not logged in user
- Select invisible captcha in the contact options in the form tab
- Open that contact menu item and send a mail as not logged in user
Actual result BEFORE applying this Pull Request
Both times is a captcha challenge executed and two mails are sent out.
Expected result AFTER applying this Pull Request
Both times is a captcha challenge executed and two mails are sent out.
Documentation Changes Required
When deprecated messages are already documented, then this one needs to be added.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries Front End Plugins Unit Tests |
| Labels |
Added:
?
PR-4.3-dev
|
||
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-08-12 13:29:42 |
| Closed_By | ⇒ | laoneo |
Closing this as it should be reverted to plugin events, as discussed here #28800.