? ? Pending

User tests: Successful: Unsuccessful:

Pull Request for Issue #38434.

Summary of Changes

unarchive

Attempting to unarchive multiple redirect links using the 'Unarchive' option in the Actions dropdown currently has no effect. When unarchiving individual redirect links, the unpublish action is used to set them to the 'Disabled' state. This update applies the same unpublish action to the bulk unarchive option.

Testing Instructions

  1. Create several redirect links.
  2. Archive the redirect links.
  3. Attempt to unarchive all archived redirect links simultaneously.

Actual result BEFORE applying this Pull Request

A form submission occurs, the page reloads, but the selected redirect links remain archived.

Expected result AFTER applying this Pull Request

The selected redirect links will be set to the unpublished/'Disabled' state.

Documentation Changes Required

None.

avatar mattelkins-bluefrontier mattelkins-bluefrontier - open - 10 Aug 2022
avatar mattelkins-bluefrontier mattelkins-bluefrontier - change - 10 Aug 2022
Status New Pending
avatar mattelkins-bluefrontier mattelkins-bluefrontier - change - 10 Aug 2022
The description was changed
avatar mattelkins-bluefrontier mattelkins-bluefrontier - edited - 10 Aug 2022
avatar joomla-cms-bot joomla-cms-bot - change - 10 Aug 2022
Category Administration com_redirect
avatar brianteeman
brianteeman - comment - 10 Aug 2022

I have tested this item successfully on ec3f60c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38434.

avatar brianteeman brianteeman - test_item - 10 Aug 2022 - Tested successfully
avatar N6REJ
N6REJ - comment - 11 Aug 2022

I have tested this item successfully on ec3f60c

Tested successfully,

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38434.

avatar N6REJ N6REJ - test_item - 11 Aug 2022 - Tested successfully
avatar richard67
richard67 - comment - 11 Aug 2022

@N6REJ You should know that seeting the RTC label only is not sufficient. It needs to change the status on github to "Ready to commit". I'll do that for you now, but hopefully you remember next time.

avatar richard67 richard67 - change - 11 Aug 2022
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 11 Aug 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38434.

avatar wilsonge wilsonge - change - 6 Sep 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-09-06 08:08:52
Closed_By wilsonge
Labels Added: ? ?
avatar wilsonge wilsonge - close - 6 Sep 2022
avatar wilsonge wilsonge - merge - 6 Sep 2022
avatar wilsonge
wilsonge - comment - 6 Sep 2022

Thankyou for you first PR to the project! Much appreciated!

avatar mattelkins-bluefrontier
mattelkins-bluefrontier - comment - 6 Sep 2022

Thankyou for you first PR to the project! Much appreciated!

Thanks! Glad to be able to contribute!

Add a Comment

Login with GitHub to post a comment