[#38426] - [4.2] Fix empty default_value check in fields plugin
- Fixed in Code Base
- 9 Aug 2022
- Medium
- Build: 4.2-dev
- # 38426
- Diff
- HLeithner:fix/menuitem
User tests: Successful: Unsuccessful:
Pull Request for Issue introduced in #18032 .
Summary of Changes
- Don't add a default_value attribute if value is NULL. This crashes GroupedlistField and maybe other fields.
- Hide default value field custom fields for the menuitem
Testing Instructions
Test custom fields, especially menuitem
Actual result BEFORE applying this Pull Request
see #38244 (comment)
Expected result AFTER applying this Pull Request
works
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_fields Front End Plugins |
I have tested this item
Works with menuitem and other custom fields.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38426.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38426.
Quy
- | Labels |
Added:
?
?
|
||
Looks good to me, just wondering why this custom field can't have a default value.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-08-09 07:19:23 |
| Closed_By | ⇒ | roland-d | |
| Labels |
Added:
Release Blocker
|
||
Thank you
Looks good to me, just wondering why this custom field can't have a default value.
I was wondering too, I only had a quick look while fixing it. It happens here:
https://github.com/joomla/joomla-cms/blob/4.2-dev/libraries/src/Form/Field/GroupedlistField.php#L134
but to me that doesn't make any sense on the first glance because I would expect that the default_value is an attribute and not an element.
But since I found the issue in the default_value === '' check I fixed this one since maybe other fields have this problem too.
If someone wants to have a look at GroupedlistField he or she is welcome to do it.
I have tested this item✅ successfully on 51ea6ce
Works as expected with the menuitem field.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38426.