[#38399] - Codestyle indent
- Fixed in Code Base
- 5 Sep 2022
- Medium
- Build: 4.2-dev
- # 38399
- Diff
- brianteeman:codestyle
User tests: Successful: Unsuccessful:
Small change to fix codestyle indent
code review
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_banners |
The failure is what caused the problem in the first place - /me confused
Me also confused because your code style looks right to me and the other not.
@HLeithner Do you have any idea why PHPCS currently accepts wrong code style in files in the drone checks but complains about this PR here?
fyi the current lack of indent comes from the psr12 work
the reason is that phpcs starts to count after <?php so the if is a position 0, I would move the if into the next line.
fyi the current lack of indent comes from the psr12 work
for phpcs it's correct for us it's bad...
thanks for the explanation. Suprised that the same situation doesnt arise with the echo directly afterwards
I can see there about 15 instances of this. If the new updated change with your recommendation passes then I will make the same change for them all
| Labels |
Added:
?
|
||
| Category | Administration com_banners | ⇒ | Administration com_banners com_categories com_contact com_content com_fields com_modules com_newsfeeds com_redirect com_tags com_users Front End Layout Modules |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38399.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38399.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38399.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-09-05 11:15:39 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
Thanks!
thanks
It seems that the PHPCS check in drone doesn’t like your changes.