Feature PR-5.0-dev Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
2 Aug 2022

I am submitting this as a new feature but it could also be considered a bug fix.

Summary of Changes

If a document is in LTR then all input fields are LTR and vice versa for RTL.

However there are several types of data that should always be LTR such as urls, email addresses and telephone numbers (https://rtlstyling.com/posts/rtl-styling#form-inputs).

For a field type of url, email and tel we can add this to the layout.

However we often use the field type of text for urls eg the custom url for joomla updates this pr also adds the ability to add dir=ltr to the xml definition of a field.

There are also some instances where the field is defined completely in the php so the direction needs to be set there as well.

Testing Instructions

complete the three tests below in both an ltr and rtl language

1. Test the url layout

Enter a link into the Click URL field of a banner
The inputting and display of the link should always be ltr

2. Test the direct input

Enter a link into the Install from URL field in the web installer
The inputting and display of the link should always be ltr
The placeholder text will also be LTR

3. Test the xml field

Enter a link to the Custom Url field of the joomla update
The inputting and display of the link should always be ltr

Current Output

1. Test the url layout

image

2. Test the direct input

image

image

3. Test the xml field

image

Expected Output with this PR

1. Test the url layout

image

2. Test the direct input

image

image

3. Test the xml field

image

31cf531 2 Aug 2022 avatar brianteeman .
avatar brianteeman brianteeman - open - 2 Aug 2022
avatar brianteeman brianteeman - change - 2 Aug 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 2 Aug 2022
Category Administration com_joomlaupdate Layout Libraries Front End Plugins
ac8e1e0 2 Aug 2022 avatar brianteeman cs
avatar brianteeman brianteeman - change - 2 Aug 2022
Labels Added: PR-4.3-dev
avatar joomla-cms-bot joomla-cms-bot - change - 7 Aug 2022
Category Administration com_joomlaupdate Layout Libraries Front End Plugins Administration com_config com_joomlaupdate com_redirect Layout Libraries Front End Plugins
avatar brianteeman
brianteeman - comment - 9 Aug 2022

update to trigger drone

avatar brianteeman
brianteeman - comment - 23 Nov 2022

update to trigger drone again

avatar Quy
Quy - comment - 25 Jan 2023

Include the following:

batch-update

avatar brianteeman
brianteeman - comment - 1 Mar 2023

resolve conflicts caused by change to array codestyle

avatar HLeithner
HLeithner - comment - 8 May 2023

This pull request has been automatically rebased to 5.0-dev. No new features will be merged into Joomla! 4.3 series. Joomla! 4.4 series is a bridge release to make migration from Joomla! 4 to 5 as smooth as possible.

avatar brianteeman brianteeman - change - 8 Sep 2023
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2023-09-08 11:50:56
Closed_By brianteeman
Labels Added: Feature PR-5.0-dev
Removed: PR-4.3-dev
avatar brianteeman brianteeman - close - 8 Sep 2023

Add a Comment

Login with GitHub to post a comment